Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561Ab3FQPlW (ORCPT ); Mon, 17 Jun 2013 11:41:22 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:59837 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab3FQPlU convert rfc822-to-8bit (ORCPT ); Mon, 17 Jun 2013 11:41:20 -0400 From: "Fernandes, Joel A" To: Arnd Bergmann CC: Tony Lindgren , "Nori, Sekhar" , "Matt Porter" , Grant Likely , "Rob Herring" , Vinod Koul , "Mark Brown" , "Cousson, Benoit" , Russell King , Rob Landley , Andrew Morton , Jason Kridner , Koen Kooi , "Devicetree Discuss" , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List Subject: RE: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding Thread-Topic: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding Thread-Index: AQHOaXCq5Ahsa0wut0SvcD1WJ4Ax1pk6GA8A///1IaA= Date: Mon, 17 Jun 2013 15:40:29 +0000 Message-ID: <083BC63EECB6FD41B8E81CF7FD87CC0F2E4E9395@DLEE08.ent.ti.com> References: <1371263570-9323-1-git-send-email-joelagnel@ti.com> <1371263570-9323-5-git-send-email-joelagnel@ti.com> <3940138.jZFEtfGGLz@wuerfel> In-Reply-To: <3940138.jZFEtfGGLz@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.170.170.90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4042 Lines: 74 Hi Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Monday, June 17, 2013 6:13 AM > To: Fernandes, Joel A > Cc: Tony Lindgren; Nori, Sekhar; Matt Porter; Grant Likely; Rob Herring; Vinod > Koul; Mark Brown; Cousson, Benoit; Russell King; Rob Landley; Andrew > Morton; Jason Kridner; Koen Kooi; Devicetree Discuss; Linux OMAP List; Linux > ARM Kernel List; Linux DaVinci Kernel List; Linux Kernel Mailing List; Linux > Documentation List; Linux MMC List; Linux SPI Devel List > Subject: Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree > binding > > On Friday 14 June 2013 21:32:47 Joel A Fernandes wrote: > > > > diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt > > b/Documentation/devicetree/bindings/dma/ti-edma.txt > > new file mode 100644 > > index 0000000..ada0018 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt > > @@ -0,0 +1,26 @@ > > +TI EDMA > > + > > +Required properties: > > +- compatible : "ti,edma3" > > +- ti,hwmods: Name of the hwmods associated to the EDMA > > +- ti,edma-regions: Number of regions > > +- ti,edma-slots: Number of slots > > + > > +Optional properties: > > +- ti,edma-xbar-event-map: Crossbar event to channel map > > You need to list #dma-cells as required here, and which values are accepted > by the driver (I suppose only <1>). You should also explain the format of the > dma-specifier for a slave here for each possible value of #dma-cells. > > For each of the standard properties (reg, interrupts, dma-channels), list > whether they are optional or required. Since the example has three > interrupts, you should probably list how many interrupts need to be specified > (minimum and maximum if the number is variable) and in what order to > expect them. [Joel] Thanks for the suggestion, I updated it and it looks like this now: Required properties: - compatible : "ti,edma3" - ti,hwmods: Name of the hwmods associated to the EDMA - ti,edma-regions: Number of regions - ti,edma-slots: Number of slots - #dma-cells: Should be set to <1> Clients should use a single number per DMA channel request. - dma-channels: Specify total DMA channels per CC - reg: Memory map for accessing module - interrupt-parent: Interrupt controller the interrupt is routed through - interrupts: Exactly 3 interrupts need to be specified in the order: 1. Transfer completion interrupt. 2. Memory protection interrupt. 3. Error interrupt. Optional properties: - ti,edma-xbar-event-map: Crossbar event to channel map Hope this looks ok. I will respin this patch and repost it in the next series spin. Thanks, Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/