Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195Ab3FQQIx (ORCPT ); Mon, 17 Jun 2013 12:08:53 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:52932 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090Ab3FQQIw (ORCPT ); Mon, 17 Jun 2013 12:08:52 -0400 MIME-Version: 1.0 In-Reply-To: <20130617120340.GE10305@atomide.com> References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> <1369995191-20855-2-git-send-email-gururaja.hebbar@ti.com> <20130617120340.GE10305@atomide.com> Date: Mon, 17 Jun 2013 18:08:51 +0200 Message-ID: Subject: Re: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management From: Linus Walleij To: Tony Lindgren Cc: Hebbar Gururaja , Haojian Zhuang , Kevin Hilman , Grant Likely , Rob Herring , "davinci-linux-open-source@linux.davincidsp.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , Vaibhav Bedia , sudhakar.raj@ti.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 38 On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren wrote: > * Linus Walleij [130617 04:38]: >> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja >> wrote: >> >> > Make pinctrl-single able to handle suspend/resume events and change >> > hogged pins states accordingly. >> > >> > Signed-off-by: Hebbar Gururaja >> > Cc: Linus Walleij >> >> Noone said anything about this patch, but it looks very straight-forward >> to me and seems sound so I have applied it. >> >> If Tony or Haojian has strong feelings about it I will dequeue it. > > I don't like the hogged pins at all as they prevent me from unloading > pinctrl-single.. But the patch seems fine to me: Hm? I think the hogged pins are the *only* pins we can reliably release when unloading the driver, look: void pinctrl_unregister(struct pinctrl_dev *pctldev) { (...) if (!IS_ERR(pctldev->p)) pinctrl_put(pctldev->p); That releases all hogged pinctrl handles when unloading a pinctrl driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/