Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953Ab3FQQv0 (ORCPT ); Mon, 17 Jun 2013 12:51:26 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:37518 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763Ab3FQQvY convert rfc822-to-8bit (ORCPT ); Mon, 17 Jun 2013 12:51:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371461892-5298-1-git-send-email-sachin.kamat@linaro.org> <1992157.1uNu7hFias@amdc1227> Date: Mon, 17 Jun 2013 09:51:22 -0700 X-Google-Sender-Auth: eE4ZYY_5dQ-6mt2w1PEp1jYzkQo Message-ID: Subject: Re: [PATCH Resend] pinctrl: exynos: Fix build breakage From: Doug Anderson To: Linus Walleij Cc: Tomasz Figa , Sachin Kamat , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Patch Tracking Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 49 Linus, On Mon, Jun 17, 2013 at 9:18 AM, Linus Walleij wrote: > On Mon, Jun 17, 2013 at 1:57 PM, Tomasz Figa wrote: >> On Monday 17 of June 2013 15:08:12 Sachin Kamat wrote: >>> 'exynos_wkup_irq_ack' should be defined ahead of its call. >>> >>> Fixes the following error: >>> drivers/pinctrl/pinctrl-exynos.c: In function ?exynos_wkup_irq_mask?: >>> drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of >>> function ?exynos_wkup_irq_ack? [-Werror=implicit-function-declaration] >>> exynos_wkup_irq_ack(irqd); >>> >>> Signed-off-by: Sachin Kamat >>> Cc: Doug Anderson >>> --- >>> Fixed the commit message. >>> --- >> >> This patch is incorrect. >> >> Compilation error is caused by merge error of Doug's patch: >> >> pinctrl: exynos: ack level-triggered interrupts before unmasking >> >> hunk of which went to wrong function - mask instead of unmask. > > OK probably I just had git am fail on me and used > patch -p1 < ... > >> Linus, could you fix it? > > No I'm afraid I will cause more trouble. > > I took out Doug's commit and this fi from my tree. > > Doug, can you respin the patch > "pinctrl: exynos: ack level-triggered interrupts before unmasking" > > On top of my "devel" branch? OK, sent. :) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/