Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414Ab3FQRIB (ORCPT ); Mon, 17 Jun 2013 13:08:01 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:44299 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753115Ab3FQRH6 (ORCPT ); Mon, 17 Jun 2013 13:07:58 -0400 From: Dmitry Torokhov To: Arnd Bergmann Cc: Chao Xie , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, haojian.zhuang@gmail.com, xiechao.mail@gmail.com Subject: Re: [PATCH V2 4/5] input: pxa27x-keypad: remove the unused members at platform data Date: Mon, 17 Jun 2013 10:07:55 -0700 Message-ID: <3957298.MQ5NXOY1oH@dtor-d630.eng.vmware.com> User-Agent: KMail/4.10.4 (Linux/3.9.4-200.fc18.x86_64; KDE/4.10.4; x86_64; ; ) In-Reply-To: <5701258.F0sLjHKir2@wuerfel> References: <1367809448-9437-1-git-send-email-chao.xie@marvell.com> <1367809448-9437-5-git-send-email-chao.xie@marvell.com> <5701258.F0sLjHKir2@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2038 Lines: 64 On Monday, June 17, 2013 03:10:27 PM Arnd Bergmann wrote: > On Sunday 05 May 2013 23:04:07 Chao Xie wrote: > > Now pxa27x-keypad make use matrix_keymap for matrix keyes, so > > remove the unused members in platform data. > > > > Signed-off-by: Chao Xie > > --- > > > > include/linux/platform_data/keypad-pxa27x.h | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/platform_data/keypad-pxa27x.h > > b/include/linux/platform_data/keypad-pxa27x.h index 0db423b..2462556 > > 100644 > > --- a/include/linux/platform_data/keypad-pxa27x.h > > +++ b/include/linux/platform_data/keypad-pxa27x.h > > @@ -39,8 +39,6 @@ struct pxa27x_keypad_platform_data { > > > > const struct matrix_keymap_data *matrix_keymap_data; > > unsigned int matrix_key_rows; > > unsigned int matrix_key_cols; > > > > - unsigned int *matrix_key_map; > > - int matrix_key_map_size; > > > > /* direct keys */ > > int direct_key_num; > > This just broke a number of configurations: > > em_x270_defconfig > ezx_defconfig > palmz72_defconfig > pxa3xx_defconfig > > You have to make sure that all these board files get converted: > > arch/arm/mach-pxa/em-x270.c > arch/arm/mach-pxa/ezx.c > arch/arm/mach-pxa/littleton.c > arch/arm/mach-pxa/mainstone.c > arch/arm/mach-pxa/mioa701.c > arch/arm/mach-pxa/palmld.c > arch/arm/mach-pxa/palmt5.c > arch/arm/mach-pxa/palmtreo.c > arch/arm/mach-pxa/palmtx.c > arch/arm/mach-pxa/palmz72.c > arch/arm/mach-pxa/tavorevb.c > arch/arm/mach-pxa/z2.c > arch/arm/mach-pxa/zylonite.c > > or leave the code to interpret that platform data in place. Sorry about this, I'll drop the patch until it gets sorted out. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/