Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753515Ab3FQR2H (ORCPT ); Mon, 17 Jun 2013 13:28:07 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:54355 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753381Ab3FQR2F (ORCPT ); Mon, 17 Jun 2013 13:28:05 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/0aGZ77orzVfgV2B+CZEDe Date: Mon, 17 Jun 2013 10:27:52 -0700 From: Tony Lindgren To: Linus Walleij Cc: Hebbar Gururaja , Haojian Zhuang , Kevin Hilman , Grant Likely , Rob Herring , "davinci-linux-open-source@linux.davincidsp.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , Vaibhav Bedia , sudhakar.raj@ti.com Subject: Re: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management Message-ID: <20130617172751.GT20992@atomide.com> References: <1369995191-20855-1-git-send-email-gururaja.hebbar@ti.com> <1369995191-20855-2-git-send-email-gururaja.hebbar@ti.com> <20130617120340.GE10305@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 51 * Linus Walleij [130617 09:14]: > On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren wrote: > > * Linus Walleij [130617 04:38]: > >> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja > >> wrote: > >> > >> > Make pinctrl-single able to handle suspend/resume events and change > >> > hogged pins states accordingly. > >> > > >> > Signed-off-by: Hebbar Gururaja > >> > Cc: Linus Walleij > >> > >> Noone said anything about this patch, but it looks very straight-forward > >> to me and seems sound so I have applied it. > >> > >> If Tony or Haojian has strong feelings about it I will dequeue it. > > > > I don't like the hogged pins at all as they prevent me from unloading > > pinctrl-single.. But the patch seems fine to me: > > Hm? I think the hogged pins are the *only* pins we can > reliably release when unloading the driver, look: In most cases all the pins can be released reliably if the pinctrl driver won't do anything with the pins on release. After all that's what bootloaders have been doing for ages :) > void pinctrl_unregister(struct pinctrl_dev *pctldev) > { > (...) > if (!IS_ERR(pctldev->p)) > pinctrl_put(pctldev->p); > > That releases all hogged pinctrl handles when unloading > a pinctrl driver. Hmm maybe I need to try it again. The last time I tried I had to comment those out, but that was a while back. And I probably had also some other hack to release pins. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/