Date: Tue, 18 Jun 2013 01:27:39 +0200
From: Andi Shyti <andi.shyti@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andi Shyti <andi@etezian.org>, arnd@arndb.de, linux-kernel@vger.kernel.org,
        pc@asdf.org, oatilla@gmail.com
Subject: Re: [PATCH 01/19] bh1770glc: added input device interface
Message-ID: <20130617232739.GA4454@jack.whiskey>
References: <cover.1371145891.git.andi@etezian.org>
 <90a9ed312d038eda11648a6ed49bb968824bf875.1371145891.git.andi@etezian.org>
 <20130617225241.GB21613@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130617225241.GB21613@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1147
Lines: 30

Hi Greg,

> > The driver generates an event in /dev/input/ under the name
> > 'bh1770'. It's a switch event where is reported '0' or '1'
> > whenever the sensor detects something crossing the threshold.
> > 
> > Signed-off-by: Onur Atilla <oatilla@gmail.com>
> > Signed-off-by: Phil Carmody <pc@asdf.org>
> > Signed-off-by: Andi Shyti <andi@etezian.org>
> > ---
> >  drivers/misc/bh1770glc.c |   58 +++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 57 insertions(+), 1 deletion(-)
> 
> Doesn't this mean that this driver is now an "input" driver, so it
> shouldn't be using the odd sysfs api, and should move to the
> drivers/input/ directory tree?

The driver has also lots of interfaces in
sysfs that are used from userspace, like proximity value and
ambient light value.

What the input interface provides is just one of the features
from the driver. Shall I move it anyway?

Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/