Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752796Ab3FQXgL (ORCPT ); Mon, 17 Jun 2013 19:36:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620Ab3FQXgI (ORCPT ); Mon, 17 Jun 2013 19:36:08 -0400 Date: Mon, 17 Jun 2013 16:36:07 -0700 From: Greg KH To: Andi Shyti Cc: Andi Shyti , arnd@arndb.de, linux-kernel@vger.kernel.org, pc@asdf.org, oatilla@gmail.com Subject: Re: [PATCH 01/19] bh1770glc: added input device interface Message-ID: <20130617233607.GC14084@kroah.com> References: <90a9ed312d038eda11648a6ed49bb968824bf875.1371145891.git.andi@etezian.org> <20130617225241.GB21613@kroah.com> <20130617232739.GA4454@jack.whiskey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130617232739.GA4454@jack.whiskey> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 36 On Tue, Jun 18, 2013 at 01:27:39AM +0200, Andi Shyti wrote: > Hi Greg, > > > > The driver generates an event in /dev/input/ under the name > > > 'bh1770'. It's a switch event where is reported '0' or '1' > > > whenever the sensor detects something crossing the threshold. > > > > > > Signed-off-by: Onur Atilla > > > Signed-off-by: Phil Carmody > > > Signed-off-by: Andi Shyti > > > --- > > > drivers/misc/bh1770glc.c | 58 +++++++++++++++++++++++++++++++++++++++++++++- > > > 1 file changed, 57 insertions(+), 1 deletion(-) > > > > Doesn't this mean that this driver is now an "input" driver, so it > > shouldn't be using the odd sysfs api, and should move to the > > drivers/input/ directory tree? > > The driver has also lots of interfaces in > sysfs that are used from userspace, like proximity value and > ambient light value. > > What the input interface provides is just one of the features > from the driver. Shall I move it anyway? Hm, why not make it an iio driver instead? That way you get input and sysfs all together. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/