Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427Ab3FQXiF (ORCPT ); Mon, 17 Jun 2013 19:38:05 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:63591 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071Ab3FQXiC (ORCPT ); Mon, 17 Jun 2013 19:38:02 -0400 MIME-Version: 1.0 In-Reply-To: <1371511350.27152.25.camel@misato.fc.hp.com> References: <1371257800-11720-1-git-send-email-yinghai@kernel.org> <1371257800-11720-5-git-send-email-yinghai@kernel.org> <1371511350.27152.25.camel@misato.fc.hp.com> Date: Mon, 17 Jun 2013 16:38:01 -0700 X-Google-Sender-Auth: TopA-q-9wL7CeVInLTNSFr7JaBo Message-ID: Subject: Re: [PATCH v5 04/22] x86, ACPI: Search buffer above 4G in second try for acpi override tables From: Yinghai Lu To: Toshi Kani Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Andrew Morton , Tejun Heo , Thomas Renninger , Tang Chen , Linux Kernel Mailing List , "Rafael J. Wysocki" , ACPI Devel Maling List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 43 On Mon, Jun 17, 2013 at 4:22 PM, Toshi Kani wrote: > On Fri, 2013-06-14 at 17:56 -0700, Yinghai Lu wrote: >> Now we only search buffer for override acpi table under 4G. >> In some case, like user use memmap to exclude all low ram, >> we may not find range for it under 4G. >> >> Do second try to search above 4G. >> >> Signed-off-by: Yinghai Lu >> Cc: "Rafael J. Wysocki" >> Cc: linux-acpi@vger.kernel.org >> Tested-by: Thomas Renninger >> Reviewed-by: Tang Chen >> Tested-by: Tang Chen >> --- >> drivers/acpi/osl.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c >> index 93e3194..42c48fc 100644 >> --- a/drivers/acpi/osl.c >> +++ b/drivers/acpi/osl.c >> @@ -627,6 +627,10 @@ void __init acpi_initrd_override(void *data, size_t size) >> /* under 4G at first, then above 4G */ >> acpi_tables_addr = memblock_find_in_range(0, (1ULL<<32) - 1, >> all_tables_size, PAGE_SIZE); >> + if (!acpi_tables_addr) >> + acpi_tables_addr = memblock_find_in_range(0, >> + ~(phys_addr_t)0, >> + all_tables_size, PAGE_SIZE); > > Should this search start from 4G, instead of 0? should be ok, as memblock searching is top-down. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/