Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753328Ab3FRAMV (ORCPT ); Mon, 17 Jun 2013 20:12:21 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:57261 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703Ab3FRAMU (ORCPT ); Mon, 17 Jun 2013 20:12:20 -0400 Date: Tue, 18 Jun 2013 02:12:16 +0200 From: Frederic Weisbecker To: Oleg Nesterov Cc: Ingo Molnar , Vince Weaver , linux-kernel@vger.kernel.org, Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , trinity@vger.kernel.org, Jiri Olsa Subject: Re: [PATCH 1/2] hw_breakpoint: Simplify *register_wide_hw_breakpoint() Message-ID: <20130618001214.GA15563@somewhere.redhat.com> References: <20130602194912.GA3277@redhat.com> <20130602195011.GB3277@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130602195011.GB3277@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 15 On Sun, Jun 02, 2013 at 09:50:11PM +0200, Oleg Nesterov wrote: > 1. register_wide_hw_breakpoint() can use unregister_ if failure, > no need to duplicate the code. > > 2. "struct perf_event **pevent" adds the unnecesary lever of > indirection and complication, use per_cpu(*cpu_events, cpu). > > Signed-off-by: Oleg Nesterov Acked-by: Frederic Weisbecker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/