Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755594Ab3FRJS3 (ORCPT ); Tue, 18 Jun 2013 05:18:29 -0400 Received: from mga03.intel.com ([143.182.124.21]:46977 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001Ab3FRJS1 (ORCPT ); Tue, 18 Jun 2013 05:18:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,887,1363158000"; d="scan'208";a="318709436" Date: Tue, 18 Jun 2013 11:17:41 +0200 From: Samuel Ortiz To: Sachin Kamat Cc: linux-kernel@vger.kernel.org, lee.jones@linaro.org Subject: Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs Message-ID: <20130618091741.GH7161@zurbaran> References: <1371025182-31386-1-git-send-email-sachin.kamat@linaro.org> <20130618084017.GA7161@zurbaran> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 44 On Tue, Jun 18, 2013 at 02:13:48PM +0530, Sachin Kamat wrote: > Hi Samuel, > > On 18 June 2013 14:10, Samuel Ortiz wrote: > > Hi Sachin, > > > > On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote: > >> devm_* APIs are device managed and make code simpler. > >> > >> Signed-off-by: Sachin Kamat > >> Cc: Miguel Aguilar > >> --- > >> CC'd Lee Jones > >> > >> Patch is based on mfd-next tree and compile tested. > >> This driver gives following compilation error (not introduced by this patch): > >> drivers/mfd/davinci_voicecodec.c:86:3: error: implicit declaration > >> of function ‘io_v2p’ [-Werror=implicit-function-declaration] > >> (dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO); > >> > >> In order to test my changes I added the following to davinci_voicecodec.h file: > >> +#define IO_OFFSET 0xfd000000 /* Virtual IO = 0xfec00000 */ > >> +#define io_v2p(va) ((va) - IO_OFFSET) > >> > >> I am not sure if these changes are right fix for the above error. > > io_v2p is define in davinci's mach/hardware.h so I believe this is what > > you should include in davinci_voicecodec.h. > > Thanks. That was only required for compile testing my patch. > Does the patch look good? Yes, but I'd appreciate if you could also fix the driver build failures as well. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/