Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755750Ab3FRJXj (ORCPT ); Tue, 18 Jun 2013 05:23:39 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:36508 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755475Ab3FRJXh convert rfc822-to-8bit (ORCPT ); Tue, 18 Jun 2013 05:23:37 -0400 MIME-Version: 1.0 In-Reply-To: <20130618091741.GH7161@zurbaran> References: <1371025182-31386-1-git-send-email-sachin.kamat@linaro.org> <20130618084017.GA7161@zurbaran> <20130618091741.GH7161@zurbaran> Date: Tue, 18 Jun 2013 14:53:37 +0530 Message-ID: Subject: Re: [PATCH Resend 1/1] mfd: davinci_voicecodec: Convert to use devm_* APIs From: Sachin Kamat To: Samuel Ortiz Cc: linux-kernel@vger.kernel.org, lee.jones@linaro.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1940 Lines: 47 On 18 June 2013 14:47, Samuel Ortiz wrote: > On Tue, Jun 18, 2013 at 02:13:48PM +0530, Sachin Kamat wrote: >> Hi Samuel, >> >> On 18 June 2013 14:10, Samuel Ortiz wrote: >> > Hi Sachin, >> > >> > On Wed, Jun 12, 2013 at 01:49:42PM +0530, Sachin Kamat wrote: >> >> devm_* APIs are device managed and make code simpler. >> >> >> >> Signed-off-by: Sachin Kamat >> >> Cc: Miguel Aguilar >> >> --- >> >> CC'd Lee Jones >> >> >> >> Patch is based on mfd-next tree and compile tested. >> >> This driver gives following compilation error (not introduced by this patch): >> >> drivers/mfd/davinci_voicecodec.c:86:3: error: implicit declaration >> >> of function ?io_v2p? [-Werror=implicit-function-declaration] >> >> (dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO); >> >> >> >> In order to test my changes I added the following to davinci_voicecodec.h file: >> >> +#define IO_OFFSET 0xfd000000 /* Virtual IO = 0xfec00000 */ >> >> +#define io_v2p(va) ((va) - IO_OFFSET) >> >> >> >> I am not sure if these changes are right fix for the above error. >> > io_v2p is define in davinci's mach/hardware.h so I believe this is what >> > you should include in davinci_voicecodec.h. >> >> Thanks. That was only required for compile testing my patch. >> Does the patch look good? > Yes, but I'd appreciate if you could also fix the driver build failures > as well. OK. I will send the fix for build error as well. However I was wondering if it is ok to include header considering multiplatform support. I am unsure in this case, hence just asking. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/