Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134Ab3FRJjp (ORCPT ); Tue, 18 Jun 2013 05:39:45 -0400 Received: from sr-smtp.usish.com ([210.5.144.203]:37529 "EHLO sr-smtp.usish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755820Ab3FRJjn (ORCPT ); Tue, 18 Jun 2013 05:39:43 -0400 X-Greylist: delayed 778 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Jun 2013 05:39:42 EDT From: "lindar_liu" To: "'Yijing Wang'" , "'James E.J. Bottomley'" Cc: , "'Hanjun Guo'" , , , References: <1371543816-15192-1-git-send-email-wangyijing@huawei.com> In-Reply-To: <1371543816-15192-1-git-send-email-wangyijing@huawei.com> Subject: RE: [PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM) Date: Tue, 18 Jun 2013 17:25:09 +0800 Message-ID: <001401ce6c05$bd0ff920$372feb60$@com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: Ac5r/N8lE9JK0PzuRpKWtYFMksVK/wABqm4Q Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2008 Lines: 59 It works, thanks. Lindar. -----Original Message----- From: Yijing Wang [mailto:wangyijing@huawei.com] Sent: Tuesday, June 18, 2013 4:24 PM To: James E.J. Bottomley Cc: linux-kernel@vger.kernel.org; Hanjun Guo; jiang.liu@huawei.com; Yijing Wang; xjtuwjp@gmail.com; lindar_liu@usish.com; linux-scsi@vger.kernel.org Subject: [PATCH 8/9] scsi/pm8001: use pdev->pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM) Pci core has been saved pm cap register offset by pdev->pm_cap in pci_pm_init() in init path. So we can use pdev->pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. Signed-off-by: Yijing Wang Cc: xjtuwjp@gmail.com Cc: lindar_liu@usish.com Cc: "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/scsi/pm8001/pm8001_init.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index e4b9bc7..3861aa1 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -912,14 +912,13 @@ static int pm8001_pci_suspend(struct pci_dev *pdev, pm_message_t state) { struct sas_ha_struct *sha = pci_get_drvdata(pdev); struct pm8001_hba_info *pm8001_ha; - int i , pos; + int i; u32 device_state; pm8001_ha = sha->lldd_ha; flush_workqueue(pm8001_wq); scsi_block_requests(pm8001_ha->shost); - pos = pci_find_capability(pdev, PCI_CAP_ID_PM); - if (pos == 0) { - printk(KERN_ERR " PCI PM not supported\n"); + if (!pdev->pm_cap) { + dev_err(&pdev->dev, " PCI PM not supported\n"); return -ENODEV; } PM8001_CHIP_DISP->interrupt_disable(pm8001_ha, 0xFF); -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/