Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754645Ab3FRJqZ (ORCPT ); Tue, 18 Jun 2013 05:46:25 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:39578 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157Ab3FRJqX (ORCPT ); Tue, 18 Jun 2013 05:46:23 -0400 From: Grant Likely Subject: Re: [PATCH v2 08/11] irqdomain: Refactor irq_domain_associate_many() To: Michael Neuling Cc: Linux Kernel Mailing List , Benjamin Herrenschmidt , Thomas Gleixner , linux-next , Linux PPC dev , Stephen Rothwell In-Reply-To: References: <1371244086-9189-1-git-send-email-grant.likely@linaro.org> <1371244086-9189-9-git-send-email-grant.likely@linaro.org> <4521.1371518445@ale.ozlabs.ibm.com> <5220.1371518734@ale.ozlabs.ibm.com> Date: Tue, 18 Jun 2013 10:46:17 +0100 Message-Id: <20130618094617.9BFA93E0D88@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 55 On Tue, 18 Jun 2013 10:05:31 +0100, Grant Likely wrote: > On Tue, Jun 18, 2013 at 2:25 AM, Michael Neuling wrote: > > Michael Neuling wrote: > > > >> Grant, > >> > >> In next-20130617 we are getting the below crash on POWER7. Bisecting, > >> points to this patch (d39046ec72 in next) > > > > Also, reverting just d39046ec72 fixes the crash in next-20130617. > > Odd. Of all the changes in that series, I would not have expected that > one to cause any problems. I'm digging into it now... Ugh. I flubbed the commit. Try this patch. It should solve the problem: >From b7ba09c29ed36eda8e16453646b55faea7f9c25f Mon Sep 17 00:00:00 2001 From: Grant Likely Date: Tue, 18 Jun 2013 10:15:19 +0100 Subject: [PATCH] irqdomain: Fix flubbed irq_domain_associate_many refactoring commit d39046ec72, "irqdomain: Refactor irq_domain_associate_many()" was missing the following hunk which causes a boot failure on anything using irq_domain_add_tree() to allocate an irq domain. Signed-off-by: Grant Likely Cc: Michael Neuling Cc: Benjamin Herrenschmidt , Cc: Thomas Gleixner , Cc: Stephen Rothwell --- include/linux/irqdomain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 02f7658..c983ed1 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -162,7 +162,7 @@ static inline struct irq_domain *irq_domain_add_tree(struct device_node *of_node const struct irq_domain_ops *ops, void *host_data) { - return irq_domain_add_linear(of_node, 0, ops, host_data); + return __irq_domain_add(of_node, 0, ~0, 0, ops, host_data); } extern void irq_domain_remove(struct irq_domain *host); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/