Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932924Ab3FROOx (ORCPT ); Tue, 18 Jun 2013 10:14:53 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39250 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932868Ab3FROOw (ORCPT ); Tue, 18 Jun 2013 10:14:52 -0400 X-Greylist: delayed 732 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Jun 2013 10:14:52 EDT X-Sasl-enc: aWS9W2BAA/LrcQRDP2uR9UbDB1cnqa+2hnuPphqSf206 1371564151 Message-ID: <51C06875.8080208@ladisch.de> Date: Tue, 18 Jun 2013 16:02:29 +0200 From: Clemens Ladisch User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Takashi Iwai CC: Wei Yongjun , yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: firewire: fix error return code in scs_probe() References: In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 19 Wei Yongjun wrote: > Fix to return -ENOMEM in the kmalloc() error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Acked-by: Clemens Ladisch > scs->buffer = kmalloc(HSS1394_MAX_PACKET_SIZE, GFP_KERNEL); > - if (!scs->buffer) > + if (!scs->buffer) { > + err = -ENOMEM; > goto err_card; > + } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/