Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756250Ab3FRPRO (ORCPT ); Tue, 18 Jun 2013 11:17:14 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:39323 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755921Ab3FRPRN (ORCPT ); Tue, 18 Jun 2013 11:17:13 -0400 MIME-Version: 1.0 In-Reply-To: <1371555182-12418-2-git-send-email-mathias.nyman@linux.intel.com> References: <1371555182-12418-1-git-send-email-mathias.nyman@linux.intel.com> <1371555182-12418-2-git-send-email-mathias.nyman@linux.intel.com> Date: Tue, 18 Jun 2013 17:17:12 +0200 Message-ID: Subject: Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support From: Linus Walleij To: Mathias Nyman Cc: Grant Likely , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 38 On Tue, Jun 18, 2013 at 1:33 PM, Mathias Nyman wrote: > Add support for gpio on Intel BayTrail platforms. BayTrail supports 3 banks > of gpios called SCORE, NCORE ans SUS with 102, 28 and 44 gpio pins. > Supports gpio interrupts and ACPI gpio events > > Pins may be muxed to alternate function instead of gpio by firmware. > This driver does not touch the pin muxing and expect firmare > to set pin muxing and pullup/down properties properly. > > Signed-off-by: Mathias Nyman I have a feeling this driver will evolve quite a bit and eventually register a pure pinctrl interface as well (currently it's only using the ranges as some data container...) Anyway, it's a good starting point and obviously (I guess?) gets your hardware up an ticking, so let's take this as a starting point. So patch applied. This thing only seems to use gpiolib-acpi.c for the basic device matching and IRQ handling backend, is that correct? What I'm thinking of moving forward is that I have seen ACPI fragments with things like "PullUp" etc, which is pinctrl domain, so we may come to need some generic ACPI helpers inside drivers/pinctrl as well sooner or later. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/