Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933720Ab3FRTAg (ORCPT ); Tue, 18 Jun 2013 15:00:36 -0400 Received: from mail-yh0-f54.google.com ([209.85.213.54]:36174 "EHLO mail-yh0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860Ab3FRTAe (ORCPT ); Tue, 18 Jun 2013 15:00:34 -0400 Date: Tue, 18 Jun 2013 12:00:27 -0700 From: Tejun Heo To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , David Rientjes , "Kirill A. Shutemov" , Fengguang Wu , Rik van Riel , Andrew Shewmaker , Jiri Kosina , Namjae Jeon , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/6] mm/writeback: Don't check force_wait to handle bdi->work_list Message-ID: <20130618190027.GF1596@htj.dyndns.org> References: <1371555222-22678-1-git-send-email-liwanp@linux.vnet.ibm.com> <1371555222-22678-2-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371555222-22678-2-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 21 On Tue, Jun 18, 2013 at 07:33:38PM +0800, Wanpeng Li wrote: > After commit 839a8e86("writeback: replace custom worker pool implementation > with unbound workqueue"), bdi_writeback_workfn runs off bdi_writeback->dwork, > on each execution, it processes bdi->work_list and reschedules if there are > more things to do instead of flush any work that race with us existing. It is > unecessary to check force_wait in wb_do_writeback since it is always 0 after > the mentioned commit. This patch remove the force_wait in wb_do_writeback. > > Signed-off-by: Wanpeng Li Reviewed-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/