Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933902Ab3FSHNF (ORCPT ); Wed, 19 Jun 2013 03:13:05 -0400 Received: from mail-ea0-f178.google.com ([209.85.215.178]:40746 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756336Ab3FSHNB (ORCPT ); Wed, 19 Jun 2013 03:13:01 -0400 Message-ID: <51C159F8.8090604@suse.cz> Date: Wed, 19 Jun 2013 09:12:56 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130124 Thunderbird/19.0 MIME-Version: 1.0 To: Tomi Valkeinen CC: Jeff Mahoney , Greg Kroah-Hartman , jirislaby@gmail.com, linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds , Alexander Shishkin , linux-usb@vger.kernel.org, Florian Tobias Schandinat , linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org, Richard Cochran , netdev@vger.kernel.org, Ben Hutchings , "Keller, Jacob E" , Michal Marek Subject: Re: [PATCH] build some drivers only when compile-testing References: <1369214326-6558-1-git-send-email-jslaby@suse.cz> <20130523022327.GB6159@kroah.com> <519D8876.9050405@suse.com> <51BF6BFF.7050705@suse.cz> <51C1595D.60706@ti.com> In-Reply-To: <51C1595D.60706@ti.com> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 28 On 06/19/2013 09:10 AM, Tomi Valkeinen wrote: > On 17/06/13 23:05, Jiri Slaby wrote: > >> The last point I inclined to the Greg's argument to remove the >> EXPERT dependency. >> >> So currently I have what is attached... Comments? > > The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're > not adding COMPILE_TEST there, but you're adding a totally new > config option, and also changing the Makefile. Look: +config USB_CHIPIDEA_IMX + bool "ChipIdea IMX support" + depends on OF_DEVICE && (ARM || COMPILE_TEST) COMPILE_TEST added here ----------------^^^^^^^^^^^^ -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/