Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933957Ab3FSHNt (ORCPT ); Wed, 19 Jun 2013 03:13:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47894 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933081Ab3FSHNs (ORCPT ); Wed, 19 Jun 2013 03:13:48 -0400 Date: Wed, 19 Jun 2013 09:13:46 +0200 From: Michal Hocko To: Glauber Costa Cc: Andrew Morton , Dave Chinner , linux-mm@kvack.org, LKML Subject: Re: linux-next: slab shrinkers: BUG at mm/list_lru.c:92 Message-ID: <20130619071346.GA9545@dhcp22.suse.cz> References: <20130617141822.GF5018@dhcp22.suse.cz> <20130617151403.GA25172@localhost.localdomain> <20130617143508.7417f1ac9ecd15d8b2877f76@linux-foundation.org> <20130617223004.GB2538@localhost.localdomain> <20130618062623.GA20528@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130618062623.GA20528@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5458 Lines: 142 On Tue 18-06-13 10:26:24, Glauber Costa wrote: [...] > Michal, would you mind testing the following patch? > > diff --git a/fs/inode.c b/fs/inode.c > index 00b804e..48eafa6 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -419,6 +419,8 @@ void inode_add_lru(struct inode *inode) > > static void inode_lru_list_del(struct inode *inode) > { > + if (inode->i_state & I_FREEING) > + return; > > if (list_lru_del(&inode->i_sb->s_inode_lru, &inode->i_lru)) > this_cpu_dec(nr_unused); > @@ -609,8 +611,8 @@ void evict_inodes(struct super_block *sb) > continue; > } > > - inode->i_state |= I_FREEING; > inode_lru_list_del(inode); > + inode->i_state |= I_FREEING; > spin_unlock(&inode->i_lock); > list_add(&inode->i_lru, &dispose); > } > @@ -653,8 +655,8 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty) > continue; > } > > - inode->i_state |= I_FREEING; > inode_lru_list_del(inode); > + inode->i_state |= I_FREEING; > spin_unlock(&inode->i_lock); > list_add(&inode->i_lru, &dispose); > } > @@ -1381,9 +1383,8 @@ static void iput_final(struct inode *inode) > inode->i_state &= ~I_WILL_FREE; > } > > + inode_lru_list_del(inode); > inode->i_state |= I_FREEING; > - if (!list_empty(&inode->i_lru)) > - inode_lru_list_del(inode); > spin_unlock(&inode->i_lock); > > evict(inode); No luck. I have this on top of inode_lru_isolate one but still can see hangs: 911 [] __wait_on_freeing_inode+0x9e/0xc0 [] find_inode_fast+0xa1/0xc0 [] iget_locked+0x4f/0x180 [] ext4_iget+0x33/0x9f0 [] ext4_lookup+0xbc/0x160 [] lookup_real+0x20/0x60 [] __lookup_hash+0x34/0x40 [] path_lookupat+0x7a2/0x830 [] filename_lookup+0x33/0xd0 [] user_path_at_empty+0x7b/0xb0 [] user_path_at+0xc/0x10 [] vfs_fstatat+0x51/0xb0 [] vfs_stat+0x16/0x20 [] sys_newstat+0x1f/0x50 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 21409 [] __wait_on_freeing_inode+0x9e/0xc0 [] find_inode_fast+0xa1/0xc0 [] iget_locked+0x4f/0x180 [] ext4_iget+0x33/0x9f0 [] ext4_lookup+0xbc/0x160 [] lookup_real+0x20/0x60 [] lookup_open+0x175/0x1d0 [] do_last+0x2de/0x780 [] path_openat+0xda/0x400 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x160/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 21745 [] path_lookupat+0x792/0x830 [] filename_lookup+0x33/0xd0 [] user_path_at_empty+0x7b/0xb0 [] user_path_at+0xc/0x10 [] vfs_fstatat+0x51/0xb0 [] vfs_stat+0x16/0x20 [] sys_newstat+0x1f/0x50 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 22032 [] path_lookupat+0x792/0x830 [] filename_lookup+0x33/0xd0 [] user_path_at_empty+0x7b/0xb0 [] user_path_at+0xc/0x10 [] vfs_fstatat+0x51/0xb0 [] vfs_stat+0x16/0x20 [] sys_newstat+0x1f/0x50 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 22621 [] __wait_on_freeing_inode+0x9e/0xc0 [] find_inode_fast+0xa1/0xc0 [] iget_locked+0x4f/0x180 [] ext4_iget+0x33/0x9f0 [] ext4_lookup+0xbc/0x160 [] lookup_real+0x20/0x60 [] lookup_open+0x175/0x1d0 [] do_last+0x2de/0x780 [] path_openat+0xda/0x400 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x160/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 22711 [] do_last+0x2c4/0x780 [] path_openat+0xda/0x400 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x160/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 22946 [] do_last+0x2c4/0x780 [] path_openat+0xda/0x400 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x160/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff 23393 [] do_last+0x2c4/0x780 [] path_openat+0xda/0x400 [] do_filp_open+0x43/0xa0 [] do_sys_open+0x160/0x1e0 [] sys_open+0x1c/0x20 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/