Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934179Ab3FSI1t (ORCPT ); Wed, 19 Jun 2013 04:27:49 -0400 Received: from mga14.intel.com ([143.182.124.37]:30839 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933976Ab3FSI1o (ORCPT ); Wed, 19 Jun 2013 04:27:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,895,1363158000"; d="scan'208";a="257109308" Date: Wed, 19 Jun 2013 10:27:40 +0200 From: Samuel Ortiz To: Lee Jones Cc: Tuomas Tynkkynen , Mark Brown , Wolfram Sang , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe Message-ID: <20130619082740.GT7161@zurbaran> References: <1371550481-28126-1-git-send-email-ttynkkynen@nvidia.com> <1371550481-28126-2-git-send-email-ttynkkynen@nvidia.com> <20130619081859.GA22998@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130619081859.GA22998@laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 32 Hi Lee, On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > changed semantics of the i2c probing for device tree devices. > > Device tree probed devices now get a NULL i2c_device_id pointer. > > This caused kernel panics due to NULL dereference. > > > > Moves the of_match_device call from tps65910_parse_dt to .probe to > > allow the chip type to be detected from device tree but with the > > device parameters coming from platform data. > > > > Signed-off-by: Tuomas Tynkkynen > > Applied with Stephen's Reviewed-by, thanks. According to Wolfgang, this is not needed as he will revert the i2c commits that are causing those crashes. I would not take it for now. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/