Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757047Ab3FSR3J (ORCPT ); Wed, 19 Jun 2013 13:29:09 -0400 Received: from mail-vb0-f52.google.com ([209.85.212.52]:48806 "EHLO mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756707Ab3FSR3G (ORCPT ); Wed, 19 Jun 2013 13:29:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371146190-16786-1-git-send-email-zoran.markovic@linaro.org> Date: Wed, 19 Jun 2013 10:29:04 -0700 X-Google-Sender-Auth: GwVBdyibDT4ECJVmMlrAzO0iZUM Message-ID: Subject: Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core From: Colin Cross To: Ulf Hansson Cc: Zoran Markovic , lkml , linux-mmc@vger.kernel.org, San Mehat , John Stultz , Chris Ball , Johan Rudholm , Jaehoon Chung , Konstantin Dorfman , Guennadi Liakhovetski , Tejun Heo , Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 33 On Wed, Jun 19, 2013 at 7:21 AM, Ulf Hansson wrote: > It seems like a bad idea that an insertion of an SD card should > trigger the display to be light up. That is indirectly in principle > what you suggest should happen from user space once a new SD card is > found. Right? Most likely what will happen is the system will mount the sdcard, and if necessary start the media scanner so that the user can see their media on the sd card when they turn the screen on. But that is mostly irrelevant, the point is that the event needs to be passed to userspace to allow it to make the decision in a timely fashion. > I have been working with Android for several years, we never used this > kind of setup. Instead we wait for the user to press the "display on" > button. At that time the confirmation will be received. Not saying > that this is the only way of doing it, but it seems to be an accepted > solution for all our customers. This patch is ported from the Android common tree, so you've probably been using it. > I agree to that this patch should have negligible impact though - if > we get things right. I will try to review the code in more detail > soon. > > Kind regards > Ulf Hansson > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/