Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964866Ab3FSTmT (ORCPT ); Wed, 19 Jun 2013 15:42:19 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:61407 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964812Ab3FSTmR (ORCPT ); Wed, 19 Jun 2013 15:42:17 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 19 Jun 2013 21:42:16 +0200 Message-ID: Subject: Re: [PATCH 04/13] cpufreq: dbx500: call CPUFREQ_POSTCHANGE notfier in error cases From: Linus Walleij To: Viresh Kumar , Rickard ANDERSSON Cc: "Rafael J. Wysocki" , linaro-kernel , Patch Tracking , cpufreq@vger.kernel.org, "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Robin Randhawa , Steve.Bannister@arm.com, Liviu Dudau , Charles Garcia-Tobin , Arvind Chauhan , dave.martin@arm.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 24 On Wed, Jun 19, 2013 at 10:52 AM, Viresh Kumar wrote: > PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both > should be called or both shouldn't be. > > In case we have started PRECHANGE notifier and found an error, we must call > POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of > calling notifiers is complete. > > This patch fixes it. > > Cc: Linus Walleij > Signed-off-by: Viresh Kumar Looks good to me. Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/