Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964886Ab3FSTpI (ORCPT ); Wed, 19 Jun 2013 15:45:08 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:37070 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935125Ab3FSTpB (ORCPT ); Wed, 19 Jun 2013 15:45:01 -0400 MIME-Version: 1.0 In-Reply-To: <1371603747-27436-3-git-send-email-rvaswani@codeaurora.org> References: <1371603747-27436-1-git-send-email-rvaswani@codeaurora.org> <1371603747-27436-3-git-send-email-rvaswani@codeaurora.org> Date: Wed, 19 Jun 2013 21:45:01 +0200 Message-ID: Subject: Re: [PATCH 2/4] drivers: gpio: msm: Fix the error condition for reading ngpio From: Linus Walleij To: Rohit Vaswani Cc: David Brown , Daniel Walker , Bryan Huntsman , Grant Likely , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 18 On Wed, Jun 19, 2013 at 3:02 AM, Rohit Vaswani wrote: > of_property_read_u32 return 0 on success. The check was using a ! to > return error. Fix the if condition. > > Signed-off-by: Rohit Vaswani Acked-by: Linus Walleij I guess this is going through the MSM tree as well? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/