Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935348Ab3FSXEo (ORCPT ); Wed, 19 Jun 2013 19:04:44 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:60791 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934170Ab3FSXEm (ORCPT ); Wed, 19 Jun 2013 19:04:42 -0400 Message-ID: <51C23900.5010202@ti.com> Date: Wed, 19 Jun 2013 19:04:32 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eduardo Valentin CC: Amit Daniel Kachhap , , Zhang Rui , , , , Kukjin Kim , Subject: Re: [PATCH V6 15/30] thermal: exynos: Return success even if no cooling data supplied References: <1371451599-31035-1-git-send-email-amit.daniel@samsung.com> <1371451599-31035-16-git-send-email-amit.daniel@samsung.com> <51C2369D.1090303@ti.com> In-Reply-To: <51C2369D.1090303@ti.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LIQUJNNXCFEHGBEQQGNG" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2880 Lines: 84 ------enig2LIQUJNNXCFEHGBEQQGNG Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 19-06-2013 18:54, Eduardo Valentin wrote: > On 17-06-2013 02:46, Amit Daniel Kachhap wrote: >> This patch removes the error return in the bind/unbind routine >> as the platform may not register any cpufreq cooling data. >> >> Acked-by: Kukjin Kim >> Acked-by: Jonghwa Lee >> Signed-off-by: Amit Daniel Kachhap >> --- >> drivers/thermal/samsung/exynos_thermal_common.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers= /thermal/samsung/exynos_thermal_common.c >> index 7064eb7..86d39aa 100644 >> --- a/drivers/thermal/samsung/exynos_thermal_common.c >> +++ b/drivers/thermal/samsung/exynos_thermal_common.c >> @@ -131,7 +131,7 @@ static int exynos_bind(struct thermal_zone_device = *thermal, >> tab_size =3D data->cooling_data.freq_clip_count; >> =20 >> if (tab_ptr =3D=3D NULL || tab_size =3D=3D 0) >> - return -EINVAL; >> + return 0; >> =20 >> /* find the cooling device registered*/ >> for (i =3D 0; i < th_zone->cool_dev_size; i++) >> @@ -180,7 +180,7 @@ static int exynos_unbind(struct thermal_zone_devic= e *thermal, >> tab_size =3D data->cooling_data.freq_clip_count; >> =20 >> if (tab_size =3D=3D 0) >> - return -EINVAL; >> + return 0; >> =20 >> /* find the cooling device registered*/ >> for (i =3D 0; i < th_zone->cool_dev_size; i++) >> >=20 > I have one question before acking this one: what happens if one > registers a TMU with no freq tab? Say the case where you have three > sensors, just like SOC_ARCH_EXYNOS5440. Would you register > cpufreq_cooling device for all of them? In other way, are you having 3 > cpufreq_cooling devices? I am actually fine with this patch. just saw that you adjust things on patch 16. Acked-by: Eduardo Valentin >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin ------enig2LIQUJNNXCFEHGBEQQGNG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlHCOQAACgkQCXcVR3XQvP24cwD7B9TdNCAKGoruGINMSS+GX/S2 yFMc0bvHfWD6gv1sggsA/2YkAfTPUEwn6tISph/okJK7QpBHfq0wr39BxdfG8seT =fQyx -----END PGP SIGNATURE----- ------enig2LIQUJNNXCFEHGBEQQGNG-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/