Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751973Ab3FTEw0 (ORCPT ); Thu, 20 Jun 2013 00:52:26 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:48427 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555Ab3FTEwY (ORCPT ); Thu, 20 Jun 2013 00:52:24 -0400 Message-ID: <51C28A63.6080905@ti.com> Date: Thu, 20 Jun 2013 10:21:47 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Linus Walleij CC: Philip Avinash , Russell King - ARM Linux , Grant Likely , Rob Herring , Rob Landley , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , Philip Avinash Subject: Re: [PATCH v2 2/4] gpio: davinci: DT changes for driver References: <1371203020-15092-1-git-send-email-avinashphilip@ti.com> <1371205241-17205-3-git-send-email-avinashphilipk@gmail.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1753 Lines: 54 On 6/20/2013 12:40 AM, Linus Walleij wrote: > On Fri, Jun 14, 2013 at 12:20 PM, Philip Avinash > wrote: > >> From: KV Sujith >> >> - Add of_device_id for Davinci GPIO driver. >> - Add function to populate data from DT. >> - Modify the probe to read from DT if DT match is found. >> - Add DT binding documentation for Davinci GPIO properties in a new file >> gpio-davinci.txt located at Documentation/devicetree/bindings/gpio/. >> >> Signed-off-by: KV Sujith >> Signed-off-by: Philip Avinash >> --- >> Changes since v1: >> - description for interrupts changed to reflecti >> interrupt array usage. > (...) > >> +static struct davinci_gpio_platform_data *davinci_gpio_set_pdata_of( >> + struct platform_device *pdev) >> +{ >> + struct device_node *dn = pdev->dev.of_node; >> + struct davinci_gpio_platform_data *pdata; >> + u32 val, ret; >> + >> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >> + if (pdata) { > > Instead of this arrow pattern: > > if (!pdata) { > dev_err( ... "out of memory allocating platform data"); > return NULL; > } > > And de-indent the rest. > > With that change: > Acked-by: Linus Walleij > > I guess this may go through the DaVinci tree with the rest of the DaVinci > patches? Linus, yes, I will pick these up with your acks. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/