Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755292Ab3FTIAV (ORCPT ); Thu, 20 Jun 2013 04:00:21 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:46046 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085Ab3FTIAS (ORCPT ); Thu, 20 Jun 2013 04:00:18 -0400 Date: Thu, 20 Jun 2013 10:00:13 +0200 From: Thomas Petazzoni To: Jingoo Han Cc: "'Kukjin Kim'" , "'Bjorn Helgaas'" , linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Grant Likely'" , "'Andrew Murray'" , "'Thierry Reding'" , "'Jason Gunthorpe'" , "'Arnd Bergmann'" , "'Surendranath Gurivireddy Balla'" , "'Siva Reddy Kallam'" , "'Thomas Abraham'" Subject: Re: [PATCH V6 3/3] ARM: dts: Add pcie controller node for Samsung EXYNOS5440 SoC Message-ID: <20130620100013.6000458f@skate> In-Reply-To: <00c301ce6d8b$d198b210$74ca1630$@samsung.com> References: <00c201ce6d85$83b072a0$8b1157e0$@samsung.com> <20130620094835.3f1f34c2@skate> <00c301ce6d8b$d198b210$74ca1630$@samsung.com> Organization: Free Electrons X-Mailer: Claws Mail 3.9.1 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 38 Dear Jingoo Han, On Thu, 20 Jun 2013 16:57:32 +0900, Jingoo Han wrote: > > > - pinctrl { > > > + pin_ctrl: pinctrl { > > > compatible = "samsung,exynos5440-pinctrl"; > > > > I know I'm nitpicking, but isn't this change completely unrelated to > > PCIe support? > > This change is related to PCIe support. > Without this, I cannot use gpio binding. > > This change was guided by Thomas Abraham (Author of Samsung pinctrl). > Also, it was confirmed by Kukjin Kim (Maintainer of Samsung SoC). > > Thank you for your caring. :) I mean, the change is fine for sure, but it should maybe part of a separate patch as it is more a fix than really the introduction of the PCIe controller node, as the patch title suggests. This would also for example allow this fix to be merged right now (for 3.11), regardless of what happens for the rest of your PCIe patches. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/