Date: Thu, 20 Jun 2013 10:33:28 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Jed Davis <jld@mozilla.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Will Deacon <will.deacon@arm.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain.
Message-ID: <20130620083327.GA5288@gmail.com>
References: <20130620030713.GA27428@mozilla.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130620030713.GA27428@mozilla.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 37


* Jed Davis <jld@mozilla.com> wrote:

> With this change, we no longer lose the innermost entry in the user-mode
> part of the call chain.  See also the x86 port, which includes the ip,
> and the corresponding change in arch/arm.
> 
> Signed-off-by: Jed Davis <jld@mozilla.com>
> ---
>  arch/arm64/kernel/perf_event.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1e49e5eb..9ba33c4 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
>  		return;
>  	}
>  
> +	perf_callchain_store(entry, regs->pc);
>  	tail = (struct frame_tail __user *)regs->regs[29];
>  
>  	while (entry->nr < PERF_MAX_STACK_DEPTH &&

Acked-by: Ingo Molnar <mingo@kernel.org>

I suspect this goes to v3.10 via the ARM64 tree?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/