Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756277Ab3FTJMX (ORCPT ); Thu, 20 Jun 2013 05:12:23 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:47729 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754182Ab3FTJMU (ORCPT ); Thu, 20 Jun 2013 05:12:20 -0400 Date: Thu, 20 Jun 2013 10:11:37 +0100 From: Will Deacon To: Ingo Molnar Cc: Jed Davis , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Catalin Marinas , Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf: arm64: Record the user-mode PC in the call chain. Message-ID: <20130620091136.GC2842@mudshark.cambridge.arm.com> References: <20130620030713.GA27428@mozilla.com> <20130620083327.GA5288@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130620083327.GA5288@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 46 On Thu, Jun 20, 2013 at 09:33:28AM +0100, Ingo Molnar wrote: > > * Jed Davis wrote: > > > With this change, we no longer lose the innermost entry in the user-mode > > part of the call chain. See also the x86 port, which includes the ip, > > and the corresponding change in arch/arm. > > > > Signed-off-by: Jed Davis > > --- > > arch/arm64/kernel/perf_event.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c > > index 1e49e5eb..9ba33c4 100644 > > --- a/arch/arm64/kernel/perf_event.c > > +++ b/arch/arm64/kernel/perf_event.c > > @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry, > > return; > > } > > > > + perf_callchain_store(entry, regs->pc); > > tail = (struct frame_tail __user *)regs->regs[29]; > > > > while (entry->nr < PERF_MAX_STACK_DEPTH && > > Acked-by: Ingo Molnar > > I suspect this goes to v3.10 via the ARM64 tree? Yup, we'll take this via the arm64 tree, thanks. Catalin, you can add: Acked-by: Will Deacon to this. Cheers, Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/