Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161190Ab3FUA2T (ORCPT ); Thu, 20 Jun 2013 20:28:19 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:52754 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965398Ab3FUA2R (ORCPT ); Thu, 20 Jun 2013 20:28:17 -0400 MIME-Version: 1.0 In-Reply-To: <20130621101600.e9cff446d5f6e21c3e8599c8@canb.auug.org.au> References: <20130617152908.1b9c999c01f18262a387dc91@canb.auug.org.au> <1371450391.658890225@f333.mail.ru> <20130621101600.e9cff446d5f6e21c3e8599c8@canb.auug.org.au> From: Grant Likely Date: Fri, 21 Jun 2013 01:27:57 +0100 X-Google-Sender-Auth: dYLTavl2wlBpOq9qup4AbrQt7Sg Message-ID: Subject: Re: linux-next: build failure after merge of the leds tree To: Stephen Rothwell Cc: Alexander Shiyan , Bryan Wu , linux-next , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 33 On Fri, Jun 21, 2013 at 1:16 AM, Stephen Rothwell wrote: > Hi Guys, > > On Mon, 17 Jun 2013 10:26:31 +0400 Alexander Shiyan wrote: >> >> > After merging the leds tree, today's linux-next build (x86_64 >> > allmodconfig) failed like this: >> > >> > drivers/leds/leds-mc13783.c: In function 'mc13xxx_led_probe': >> > drivers/leds/leds-mc13783.c:280:4: error: implicit declaration of function 'of_get_next_child' [-Werror=implicit-function-declaration] >> > child = of_get_next_child(parent, child); >> > ^ >> > >> > Caused by commit 2ca3a455432f ("leds: leds-mc13783: Add devicetree support"). of_get_next_child() is only defined if CONFIG_OF is set. >> > >> > I have used the version of the leds tree from next-20130607 for today. >> >> The patch has already been sent by me. >> http://www.spinics.net/lists/linux-leds/msg00994.html > > I anything happening about this? That patch would need to go into the > leds tree (with acks from devicetree people - Grant cc'd). I've gone and looked at the patch. It should be reverted and revisited. It interleaves a bunch of DT calls with non-DT calls which the absence of empty stubs when !CONFIG_OF is intended to catch. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/