Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161358Ab3FUBsr (ORCPT ); Thu, 20 Jun 2013 21:48:47 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:45597 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161328Ab3FUBsp (ORCPT ); Thu, 20 Jun 2013 21:48:45 -0400 From: "Yang, Wenyou" To: Boris BREZILLON , Wim Van Sebroeck , Jean-Christophe Plagniol-Villard , "Ferre, Nicolas" , "linux-watchdog@vger.kernel.org" CC: "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RFC PATCH 0/4] watchdog: at91sam9_wdt: handle already configured wdt Thread-Topic: [RFC PATCH 0/4] watchdog: at91sam9_wdt: handle already configured wdt Thread-Index: AQHOZpI0IuW+ka8EMUSM1wj0O7ALbJk/c1+Q Date: Fri, 21 Jun 2013 01:47:40 +0000 Message-ID: References: <1370947890-954-1-git-send-email-b.brezillon@overkiz.com> In-Reply-To: <1370947890-954-1-git-send-email-b.brezillon@overkiz.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r5L1munl005490 Content-Length: 3145 Lines: 79 > -----Original Message----- > From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] > On Behalf Of Boris BREZILLON > Sent: 2013??6??11?? 18:51 > To: Wim Van Sebroeck; Jean-Christophe Plagniol-Villard; Ferre, Nicolas; > linux-watchdog@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org; linux-doc@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Boris > BREZILLON > Subject: [RFC PATCH 0/4] watchdog: at91sam9_wdt: handle already configured > wdt > > Hello, > > This patch series is a porposal to enhance the sam9 watchdog timer support. > > The at91sam9 watchdog timer cannot configured twice, and the current > implementation only tries to configure in a static way: > - 2 seconds timeout > - wdt restart every 500ms > > If the timer has already been configured with different values, it returns an > error and do not create any watchdog device. > > This is not critical if the watchdog is disabled, but if it has been enabled with > different timeout values it will lead to a SoC reset. > > This patch series tries to address this issue by adapting the heartbeat value > according the WDT timer config: > - it first tries to configure the timer as requested. > - if it fails it fallbacks to the current config, adapting its heartbeat timer > to the needs > > This patch series also move to a dynamically allocated at91wdt device instead > of the static instance. I'm not sure this is the best solution, so please tell > me if you prefer to keep static instance of watchdog. > > It adds a new at91 wdt type: software. This new type make use of the at91 wdt > interrupt to trigger a software watchdog. > > Finally it adds several properties to the device tree bindings. > > Best Regards, > Boris > > Boris BREZILLON (4): > watchdog: at91sam9_wdt: better watchdog support > watchdog: at91sam9_wdt: update device tree doc > ARM: at91/dt: add sam9 watchdog default options to SoCs > ARM: at91/dt: add watchdog properties to kizbox board > > .../devicetree/bindings/watchdog/atmel-wdt.txt | 30 +- > arch/arm/boot/dts/at91sam9260.dtsi | 5 + > arch/arm/boot/dts/at91sam9263.dtsi | 5 + > arch/arm/boot/dts/at91sam9g45.dtsi | 5 + > arch/arm/boot/dts/at91sam9n12.dtsi | 5 + > arch/arm/boot/dts/at91sam9x5.dtsi | 5 + > arch/arm/boot/dts/kizbox.dts | 6 + > arch/arm/boot/dts/sama5d3.dtsi | 5 + > drivers/watchdog/at91sam9_wdt.c | 319 > +++++++++++++++----- > 9 files changed, 300 insertions(+), 85 deletions(-) > > -- > 1.7.9.5 > > Tested on sama5d34ek, at91sam9g25ek, linux-next_20130620 Tested by Wenyou Yang > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?