Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423067Ab3FUDAP (ORCPT ); Thu, 20 Jun 2013 23:00:15 -0400 Received: from mail-pb0-f50.google.com ([209.85.160.50]:51178 "EHLO mail-pb0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422896Ab3FUDAN (ORCPT ); Thu, 20 Jun 2013 23:00:13 -0400 MIME-Version: 1.0 In-Reply-To: <20130621013045.GJ23042@agk-dp.fab.redhat.com> References: <1371763260-9933-1-git-send-email-gcondra@google.com> <20130621005905.GI23042@agk-dp.fab.redhat.com> <20130621013045.GJ23042@agk-dp.fab.redhat.com> Date: Thu, 20 Jun 2013 20:00:12 -0700 Message-ID: Subject: Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors. From: Geremy Condra To: Geremy Condra , dm-devel@redhat.com, wad@chromium.org, linux-kernel@vger.kernel.org, agk@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 26 On Thu, Jun 20, 2013 at 6:30 PM, Alasdair G Kergon wrote: > On Thu, Jun 20, 2013 at 06:12:07PM -0700, Geremy Condra wrote: >> Assuming nobody currently using DM_UEVENT minds it doesn't cause any >> problems for me. Any current users object? > > DM_UEVENT toggles uevents on or off across the whole of device-mapper. > > If there is no particular need for verity *not* to generate uevents > while other parts of device-mapper *are* generating them, then we can > make do with just the one Kconfig parameter. (Userspace is still free > to ignore particular events.) > > So let's drop the second config parameter. SGTM, next patch coming up- thanks for taking the time to review! Geremy Condra > > Alasdair > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/