Date: Thu, 20 Jun 2013 22:56:30 -0500
From: Rob Landley <rob@landley.net>
Subject: Re: [PATCH] nbd: correct disconnect behavior
To: Paul Clements <paul.clements@steeleye.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        paul.clements@steeleye.com, nbd-general@lists.sourceforge.net
References: <20130619210918.DF616222D8@clements>
In-Reply-To: <20130619210918.DF616222D8@clements> (from
	paul.clements@steeleye.com on Wed Jun 19 16:09:18 2013)
Message-Id: <1371786990.2776.137@driftwood>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1234
Lines: 32

On 06/19/2013 04:09:18 PM, Paul Clements wrote:
> Currently, when a disconnect is requested by the user (via  
> NBD_DISCONNECT
> ioctl) the return from NBD_DO_IT is undefined (it is usually one of
> several error codes). This means that nbd-client does not know if a
> manual disconnect was performed or whether a network error occurred.
> Because of this, nbd-client's persist mode (which tries to reconnect  
> after
> error, but not after manual disconnect) does not always work  
> correctly.
> 
> This change fixes this by causing NBD_DO_IT to always return 0 if a  
> user
> requests a disconnect. This means that nbd-client can correctly either
> persist the connection (if an error occurred) or disconnect (if the  
> user
> requested it).
> 
> Signed-off-by: Paul Clements <paul.clements@steeleye.com>

Is _that_ what it was?

(Guy who wrote the busybox NBD client and never did quite understand  
the disconnect/reconnect behavior.)

Acked-by: Rob Landley <rob@landley.net>

Rob--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/