Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377Ab3FWIgQ (ORCPT ); Sun, 23 Jun 2013 04:36:16 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:51311 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751022Ab3FWIgO (ORCPT ); Sun, 23 Jun 2013 04:36:14 -0400 Message-ID: <1371976573.3137.20.camel@joe-AO722> Subject: Re: [PATCH] x86, tboot: provide debugfs interfaces to access TXT log From: Joe Perches To: Qiaowei Ren Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Gang Wei Date: Sun, 23 Jun 2013 01:36:13 -0700 In-Reply-To: <1371974050-21436-1-git-send-email-qiaowei.ren@intel.com> References: <1371974050-21436-1-git-send-email-qiaowei.ren@intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 39 On Sun, 2013-06-23 at 15:54 +0800, Qiaowei Ren wrote: > These logs come from tboot (Trusted Boot, an open source, > pre-kernel/VMM module that uses Intel TXT to perform a > measured and verified launch of an OS kernel/VMM.). [] > diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c [] > +static struct tboot_log *get_log(void) > +{ > + struct tboot_log *log; > + > + log = (struct tboot_log *)ioremap_nocache(TBOOT_SERIAL_LOG_ADDR, > + TBOOT_SERIAL_LOG_SIZE); You might want to fix the sparse errors. CHECK arch/x86/kernel/tboot.c arch/x86/kernel/tboot.c:362:16: warning: cast removes address space of expression arch/x86/kernel/tboot.c:368:25: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/tboot.c:368:25: expected void volatile [noderef] *addr arch/x86/kernel/tboot.c:368:25: got struct tboot_log *[assigned] log arch/x86/kernel/tboot.c:395:17: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/tboot.c:395:17: expected void volatile [noderef] *addr arch/x86/kernel/tboot.c:395:17: got struct tboot_log *[assigned] log arch/x86/kernel/tboot.c:479:16: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/tboot.c:479:16: expected void *config arch/x86/kernel/tboot.c:479:16: got void [noderef] * arch/x86/kernel/tboot.c:485:19: warning: incorrect type in assignment (different address spaces) arch/x86/kernel/tboot.c:485:19: expected void *heap_base arch/x86/kernel/tboot.c:485:19: got void [noderef] * arch/x86/kernel/tboot.c:487:17: warning: incorrect type in argument 1 (different address spaces) arch/x86/kernel/tboot.c:487:17: expected void volatile [noderef] *addr arch/x86/kernel/tboot.c:487:17: got void *config -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/