Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751092Ab3FWJ2J (ORCPT ); Sun, 23 Jun 2013 05:28:09 -0400 Received: from mail-vc0-f175.google.com ([209.85.220.175]:59420 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883Ab3FWJ2D (ORCPT ); Sun, 23 Jun 2013 05:28:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371146190-16786-1-git-send-email-zoran.markovic@linaro.org> Date: Sun, 23 Jun 2013 11:28:01 +0200 Message-ID: Subject: Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core From: Ulf Hansson To: Colin Cross Cc: Zoran Markovic , lkml , linux-mmc@vger.kernel.org, San Mehat , John Stultz , Chris Ball , Johan Rudholm , Jaehoon Chung , Konstantin Dorfman , Guennadi Liakhovetski , Tejun Heo , Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1804 Lines: 41 On 19 June 2013 19:29, Colin Cross wrote: > On Wed, Jun 19, 2013 at 7:21 AM, Ulf Hansson wrote: >> It seems like a bad idea that an insertion of an SD card should >> trigger the display to be light up. That is indirectly in principle >> what you suggest should happen from user space once a new SD card is >> found. Right? > > Most likely what will happen is the system will mount the sdcard, and > if necessary start the media scanner so that the user can see their > media on the sd card when they turn the screen on. But that is mostly > irrelevant, the point is that the event needs to be passed to > userspace to allow it to make the decision in a timely fashion. > >> I have been working with Android for several years, we never used this >> kind of setup. Instead we wait for the user to press the "display on" >> button. At that time the confirmation will be received. Not saying >> that this is the only way of doing it, but it seems to be an accepted >> solution for all our customers. > > This patch is ported from the Android common tree, so you've probably > been using it. We removed more or less all Android code in the mmc subsystem, since it just didn't work. :-) The "deferred resume" was very useful though, so after some rework we kept it and could then improve the system resume time significantly. > >> I agree to that this patch should have negligible impact though - if >> we get things right. I will try to review the code in more detail >> soon. >> >> Kind regards >> Ulf Hansson >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/