Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888Ab3FWPsw (ORCPT ); Sun, 23 Jun 2013 11:48:52 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:35126 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354Ab3FWPst (ORCPT ); Sun, 23 Jun 2013 11:48:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371896189-5475-1-git-send-email-prabhakar.csengg@gmail.com> From: Prabhakar Lad Date: Sun, 23 Jun 2013 21:18:20 +0530 Message-ID: Subject: Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing To: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab , LMML , Hans Verkuil , Laurent Pinchart , DLOS , LKML , Hans Verkuil , Sakari Ailus Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3158 Lines: 90 Hi Guennadi, Thanks for the review. On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski wrote: > On Sat, 22 Jun 2013, Prabhakar Lad wrote: > >> From: "Lad, Prabhakar" >> >> Both synchronous and asynchronous tvp514x subdevice probing is supported by >> this patch. >> >> Signed-off-by: Prabhakar Lad >> Cc: Guennadi Liakhovetski >> Cc: Laurent Pinchart >> Cc: Hans Verkuil >> Cc: Sakari Ailus >> Cc: Mauro Carvalho Chehab >> --- >> drivers/media/i2c/tvp514x.c | 22 +++++++++++++++------- >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c >> index 864eb14..d090caf 100644 >> --- a/drivers/media/i2c/tvp514x.c >> +++ b/drivers/media/i2c/tvp514x.c >> @@ -36,6 +36,7 @@ >> #include >> #include >> >> +#include >> #include >> #include >> #include > > Ok, but this one really does too many things in one patch: > >> @@ -1148,9 +1149,9 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) >> /* Register with V4L2 layer as slave device */ >> sd = &decoder->sd; >> v4l2_i2c_subdev_init(sd, client, &tvp514x_ops); >> - strlcpy(sd->name, TVP514X_MODULE_NAME, sizeof(sd->name)); >> >> #if defined(CONFIG_MEDIA_CONTROLLER) >> + strlcpy(sd->name, TVP514X_MODULE_NAME, sizeof(sd->name)); > > This is unrelated > OK I'll split the patch or may be a line in a commit message can do ? >> decoder->pad.flags = MEDIA_PAD_FL_SOURCE; >> decoder->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >> decoder->sd.entity.flags |= MEDIA_ENT_T_V4L2_SUBDEV_DECODER; >> @@ -1176,16 +1177,22 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) >> sd->ctrl_handler = &decoder->hdl; >> if (decoder->hdl.error) { >> ret = decoder->hdl.error; >> - >> - v4l2_ctrl_handler_free(&decoder->hdl); >> - return ret; >> + goto done; >> } >> v4l2_ctrl_handler_setup(&decoder->hdl); >> >> - v4l2_info(sd, "%s decoder driver registered !!\n", sd->name); >> - >> - return 0; >> + ret = v4l2_async_register_subdev(&decoder->sd); >> + if (!ret) >> + v4l2_info(sd, "%s decoder driver registered !!\n", sd->name); >> >> +done: >> + if (ret < 0) { >> + v4l2_ctrl_handler_free(&decoder->hdl); >> +#if defined(CONFIG_MEDIA_CONTROLLER) >> + media_entity_cleanup(&decoder->sd.entity); > > So is this - it wasn't called before in the "if (decoder->hdl.error)" case > above. > Yes so fixed it up here. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/