Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753137Ab3FXIYZ (ORCPT ); Mon, 24 Jun 2013 04:24:25 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:47506 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548Ab3FXIYX (ORCPT ); Mon, 24 Jun 2013 04:24:23 -0400 MIME-Version: 1.0 In-Reply-To: <201306240911.14288.hverkuil@xs4all.nl> References: <1371896189-5475-1-git-send-email-prabhakar.csengg@gmail.com> <201306240911.14288.hverkuil@xs4all.nl> From: Prabhakar Lad Date: Mon, 24 Jun 2013 13:54:02 +0530 Message-ID: Subject: Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing To: Hans Verkuil Cc: Guennadi Liakhovetski , Mauro Carvalho Chehab , LMML , Hans Verkuil , Laurent Pinchart , DLOS , LKML , Sakari Ailus Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2754 Lines: 73 Hi Hans, On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote: > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote: >> Hi Guennadi, >> >> Thanks for the review. >> >> On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski >> wrote: >> > On Sat, 22 Jun 2013, Prabhakar Lad wrote: >> > >> >> From: "Lad, Prabhakar" >> >> >> >> Both synchronous and asynchronous tvp514x subdevice probing is supported by >> >> this patch. >> >> >> >> Signed-off-by: Prabhakar Lad >> >> Cc: Guennadi Liakhovetski >> >> Cc: Laurent Pinchart >> >> Cc: Hans Verkuil >> >> Cc: Sakari Ailus >> >> Cc: Mauro Carvalho Chehab >> >> --- >> >> drivers/media/i2c/tvp514x.c | 22 +++++++++++++++------- >> >> 1 file changed, 15 insertions(+), 7 deletions(-) >> >> >> >> diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c >> >> index 864eb14..d090caf 100644 >> >> --- a/drivers/media/i2c/tvp514x.c >> >> +++ b/drivers/media/i2c/tvp514x.c >> >> @@ -36,6 +36,7 @@ >> >> #include >> >> #include >> >> >> >> +#include >> >> #include >> >> #include >> >> #include >> > >> > Ok, but this one really does too many things in one patch: >> > >> >> @@ -1148,9 +1149,9 @@ tvp514x_probe(struct i2c_client *client, const struct i2c_device_id *id) >> >> /* Register with V4L2 layer as slave device */ >> >> sd = &decoder->sd; >> >> v4l2_i2c_subdev_init(sd, client, &tvp514x_ops); >> >> - strlcpy(sd->name, TVP514X_MODULE_NAME, sizeof(sd->name)); >> >> >> >> #if defined(CONFIG_MEDIA_CONTROLLER) >> >> + strlcpy(sd->name, TVP514X_MODULE_NAME, sizeof(sd->name)); >> > >> > This is unrelated >> > >> OK I'll split the patch or may be a line in a commit message can do ? > > Please split it up in two patches. > > Why is sd->name set anyway? And why is it moved under CONFIG_MEDIA_CONTROLLER? > It's not obvious to me. > while using tvp514x subdev with media controller based drivers, when we enumerate entities (MEDIA_IOC_ENUM_ENTITIES) to get the index id of the entity we compare the entity name with "tvp514x", So I moved it under CONFIG_MEDIA_CONTROLLER config. I hope you are OK with moving this in a separate patch. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/