Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032Ab3FXMhU (ORCPT ); Mon, 24 Jun 2013 08:37:20 -0400 Received: from mail-oa0-f53.google.com ([209.85.219.53]:35158 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954Ab3FXMhR (ORCPT ); Mon, 24 Jun 2013 08:37:17 -0400 MIME-Version: 1.0 In-Reply-To: <20130617180212.GU20992@atomide.com> References: <1370980749-15383-1-git-send-email-linus.walleij@stericsson.com> <51BA1FE7.4000900@wwwdotorg.org> <51BB3A2C.608@wwwdotorg.org> <20130617072021.GB4465@atomide.com> <20130617180212.GU20992@atomide.com> Date: Mon, 24 Jun 2013 14:37:16 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: document the pinctrl PM states From: Linus Walleij To: Tony Lindgren Cc: Stephen Warren , Linus Walleij , Stephen Warren , Kevin Hilman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Ulf Hansson Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1521 Lines: 39 On Mon, Jun 17, 2013 at 8:02 PM, Tony Lindgren wrote: > * Linus Walleij [130617 09:11]: >> Bear in mind that struct pinctl * forks effects in two paths, >> one is muxing the other is config, like pull-ups etc. > > I also thought the plan was to merge pinmux and pinconf and > do things based the named modes? That is done from a consumer point of view. Consumers only care about pinctrl * handles and pinctrl_state * switches. > The last time I tried using the pinconf functions it involved > knowing the name of the pin in the consumer driver. The name > may not be very descriptive in the device tree cases at least > for the pinctrl-single. So I did not pay much attention to > the pinconf functions. Consumers should not use that interface, i.e.: int pin_config_get(const char *dev_name, const char *name, unsigned long *config); int pin_config_set(const char *dev_name, const char *name, unsigned long config) This needs to be deleted from I'll see if I can get rid of it pronto to avoid any more confusion and sorry for leaving that in place for too long. The proper way to use it is to use the states. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/