Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557Ab3FXTYM (ORCPT ); Mon, 24 Jun 2013 15:24:12 -0400 Received: from mail.skyhub.de ([78.46.96.112]:58175 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936Ab3FXTYK (ORCPT ); Mon, 24 Jun 2013 15:24:10 -0400 Date: Mon, 24 Jun 2013 21:24:04 +0200 From: Borislav Petkov To: Peter Zijlstra Cc: Robert Richter , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa , linux-kernel@vger.kernel.org, Borislav Petkov , Robert Richter Subject: Re: [PATCH v2 02/14] perf: Add persistent events Message-ID: <20130624192404.GA24827@pd.tnic> References: <1370968960-22527-1-git-send-email-rric@kernel.org> <1370968960-22527-3-git-send-email-rric@kernel.org> <20130624092807.GM28407@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130624092807.GM28407@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 21 On Mon, Jun 24, 2013 at 11:28:07AM +0200, Peter Zijlstra wrote: > I find this patch incomplete for its asymmetric; there a dec, but not an > implied inc. There's one in perf_mmap_open. Basically the idea was to pull up the ->mmap_count decrement (haha, sounds like excrement :-)) and not deallocate the ring buffers for a persistent event. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/