Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509Ab3FXUKT (ORCPT ); Mon, 24 Jun 2013 16:10:19 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:33747 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745Ab3FXUKQ (ORCPT ); Mon, 24 Jun 2013 16:10:16 -0400 MIME-Version: 1.0 In-Reply-To: <51C82C3C.8040506@ti.com> References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306211632.12577.arnd@arndb.de> <201306212044.26677.arnd@arndb.de> <51C82C3C.8040506@ti.com> Date: Mon, 24 Jun 2013 15:10:15 -0500 Message-ID: Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA From: Joel A Fernandes To: Sekhar Nori Cc: Arnd Bergmann , Joel A Fernandes , Tony Lindgren , Matt Porter , Grant Likely , Rob Herring , Vinod Koul , Mark Brown , Benoit Cousson , Russell King , Rob Landley , Andrew Morton , Jason Kridner , Koen Kooi , Devicetree Discuss , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 58 On Mon, Jun 24, 2013 at 6:23 AM, Sekhar Nori wrote: > On 6/22/2013 3:23 AM, Joel A Fernandes wrote: >> Hi Arnd, >> >> On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >>> On Friday 21 June 2013, Joel A Fernandes wrote: >>>> I think we are talking about different things, I agree the 'select >>>> DMADEVICES' can be dropped but lets please keep the default y option >>>> (not adding new select statements, just saying that if someone select >>>> DMADEVICES in menuconfig and if they're ARCH_OMAP=1 , then default to >>>> EDMA). This will simply allow people to have a default. Thanks. >>> >>> Yes, that's ok. >> >> Ok, thanks. I will follow up with a patch in my next submissions that builds it. >> >> Perhaps a: >> default y if 'ARCH_OMAP2PLUS' >> >> and leave the existing as it is... >> default n if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2' >> >> would make most sense to me. Basically EDMA is seen on current and all >> new OMAP2PLUS. > > OMAP2PLUS devices like OMAP3/4 do not have EDMA so this is not really true. Sure. Right now though, and from what I've seen, all future SoCs are supporting EDMA. >> >>> >>> config TI_EDMA >>> tristate "TI EDMA support" >>> default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >>> select DMA_ENGINE >>> select DMA_VIRTUAL_CHANNELS >> >> >> >> MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The >> 'm' option will require some initramfs to load the module when needing >> to MMC boot, I suggest lets leave it as y. > > But there is no reason why it cannot work with PIO, right? Sounds like > the right fix is in driver. I am not sure about this. I agree no reason it cannot do PIO. I will check. But even if it did, loading EDMA as a module will require omap_hsmmc to switch to DMA mode which I am sure the driver doesn't support today. Thanks, Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/