Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197Ab3FXVKx (ORCPT ); Mon, 24 Jun 2013 17:10:53 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:48398 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065Ab3FXVKv convert rfc822-to-8bit (ORCPT ); Mon, 24 Jun 2013 17:10:51 -0400 From: "Fernandes, Joel A" To: Arnd Bergmann , Joel A Fernandes CC: "Nori, Sekhar" , Tony Lindgren , "Matt Porter" , Grant Likely , "Rob Herring" , Vinod Koul , "Mark Brown" , "Cousson, Benoit" , Russell King , Rob Landley , Andrew Morton , Jason Kridner , Koen Kooi , "Devicetree Discuss" , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List Subject: RE: [PATCH v12 05/11] edma: config: Enable config options for EDMA Thread-Topic: [PATCH v12 05/11] edma: config: Enable config options for EDMA Thread-Index: AQHObfoZdlSH5JEXIkOVso7HMXcpAplASIaAgAA8ZgCAAAIzAIAABZOAgAADZwCAAEV1AIAAAQQAgAA09ICAAAWtAIAATfYAgARLc4CAAAEQgIAACeSA//+sj6A= Date: Mon, 24 Jun 2013 21:09:58 +0000 Message-ID: <083BC63EECB6FD41B8E81CF7FD87CC0F2E4EE5A1@DLEE08.ent.ti.com> References: <1371762407-24544-1-git-send-email-joelagnel@ti.com> <201306242228.23297.arnd@arndb.de> <201306242307.35840.arnd@arndb.de> In-Reply-To: <201306242307.35840.arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.247.5.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 41 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Monday, June 24, 2013 4:08 PM > To: Joel A Fernandes > Cc: Nori, Sekhar; Fernandes, Joel A; Tony Lindgren; Matt Porter; Grant Likely; > Rob Herring; Vinod Koul; Mark Brown; Cousson, Benoit; Russell King; Rob > Landley; Andrew Morton; Jason Kridner; Koen Kooi; Devicetree Discuss; Linux > OMAP List; Linux ARM Kernel List; Linux DaVinci Kernel List; Linux Kernel > Mailing List; Linux Documentation List; Linux MMC List; Linux SPI Devel List > Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA > > On Monday 24 June 2013, Joel A Fernandes wrote: > > >> Yes sure, right now they are defined as follows in include/linux/edma.h: > > >> > > >> #if defined(CONFIG_TI_EDMA) || defined(CONFIG_TI_EDMA_MODULE) > bool > > >> edma_filter_fn(struct dma_chan *, void *); #else static inline bool > > >> edma_filter_fn(struct dma_chan *chan, void *param) { return false; > > >> } #endif > > > > > > It's best to just define the filter function in the platform code > > > and pass a pointer to it through platform data. The way you do it > > > above makes the slave drivers inherently nonportable. > > > > But with DT-only platforms, can you really do that? > > The nice thing about this is that with a DT-only platform, the filter function will > automatically go away: you have no platform_data, which means that if you > are using dma_request_slave_channel_compat, you just pass NULL as the filter > and the filter-data, same as just calling dma_request_slave_channel. > [Joel] Ah yes! Thanks for that. Right, edma_filter_fn is not passed explicitly for DT case. Thanks, Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/