MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <51C92607.7050403@samsung.com>
Date: Tue, 25 Jun 2013 14:09:27 +0900
From: jonghwa3.lee@samsung.com
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411
 Thunderbird/11.0.1
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: anton.vorontsov@linaro.org, linux-kernel@vger.kernel.org,
        Myungjoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 1/2] power: charger-manager: regulator_get() never returns
 NULL.
References: <1372136569-551-1-git-send-email-jonghwa3.lee@samsung.com>
 <CAK9yfHxLDiu7tagRhPEK1aCCTYnMH7i2yKrtqquAwnfxHnZxSg@mail.gmail.com>
In-reply-to: <CAK9yfHxLDiu7tagRhPEK1aCCTYnMH7i2yKrtqquAwnfxHnZxSg@mail.gmail.com>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1642
Lines: 47

On 2013년 06월 25일 14:07, Sachin Kamat wrote:

> On 25 June 2013 10:32, Jonghwa Lee <jonghwa3.lee@samsung.com> wrote:
>> This patch fixes return value checking of regulator_get() in charger-manager
>> driver. The API, regulator_get(), returns ERR_PTR() when it fails to get
>> regulator with given name, not NULL.
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
>> Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
>> ---
>>  drivers/power/charger-manager.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
>> index ba42029..7d1bcde 100644
>> --- a/drivers/power/charger-manager.c
>> +++ b/drivers/power/charger-manager.c
>> @@ -1239,7 +1239,7 @@ static int charger_manager_register_extcon(struct charger_manager *cm)
>>
>>                 charger->consumer = regulator_get(cm->dev,
>>                                         charger->regulator_name);
>> -               if (charger->consumer == NULL) {
>> +               if (IS_ERR(charger->consumer)) {
>>                         dev_err(cm->dev, "Cannot find charger(%s)\n",
>>                                 charger->regulator_name);
>>                         ret = -EINVAL;
> 
>  You can as well make this ret = PTR_ERR(charger->consumer).


Yes, I'll fix it.

Thanks,
Jonghwa

> 
> ---
> With warm regards,
> Sachin
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/