Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676Ab3FYG0P (ORCPT ); Tue, 25 Jun 2013 02:26:15 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:63172 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751414Ab3FYG0N (ORCPT ); Tue, 25 Jun 2013 02:26:13 -0400 MIME-Version: 1.0 In-Reply-To: <20130624152553.GT27646@sirena.org.uk> References: <1372066617-23518-1-git-send-email-sachin.kamat@linaro.org> <20130624152553.GT27646@sirena.org.uk> Date: Tue, 25 Jun 2013 11:56:12 +0530 Message-ID: Subject: Re: [PATCH 1/1] of/documentation: Update s5m8767-regulator bindings document From: Sachin Kamat To: Mark Brown Cc: devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, grant.likely@linaro.org, rob@landley.net, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 24 On 24 June 2013 20:55, Mark Brown wrote: > On Mon, Jun 24, 2013 at 03:06:57PM +0530, Sachin Kamat wrote: >> s5m8767 regulator is used on Exynos platforms which use pin controller >> to configure GPIOs. Update the example accordingly. > > This smells bad, why does a driver using GPIOs through the GPIO API see > a change in the binding? There is no change in the bindings, but just a correction in the documentation to reflect the implementation. Earlier when Samsung platforms did not have pinctrl driver, legacy GPIO driver was used which took those 5 parameters. Now since we are using pinctrl, we need only 3 parameters. The document was somehow not updated to reflect this change. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/