Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947Ab3FYHLm (ORCPT ); Tue, 25 Jun 2013 03:11:42 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:37281 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113Ab3FYHLl (ORCPT ); Tue, 25 Jun 2013 03:11:41 -0400 Message-ID: <51C942A9.9070904@collabora.co.uk> Date: Tue, 25 Jun 2013 09:11:37 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Thomas Gleixner CC: Grant Likely , Ingo Molnar , Linus Walleij , Samuel Ortiz , Jason Cooper , Andrew Lunn , Russell King , Ralf Baechle , Benjamin Herrenschmidt , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , linux-mips Subject: Re: [PATCH 0/7] genirq: add irq_get_trigger_type() to get IRQ flags References: <1371228049-27080-1-git-send-email-javier.martinez@collabora.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 42 On 06/18/2013 12:29 AM, Grant Likely wrote: > On Fri, Jun 14, 2013 at 5:40 PM, Javier Martinez Canillas > wrote: >> Drivers that want to get the trigger edge/level type flags for a >> given interrupt have to first call irq_get_irq_data(irq) to get >> the struct irq_data and then irqd_get_trigger_type(irq_data) to >> obtain the IRQ flags. >> >> This is not only error prone but also unnecessary exposes the >> struct irq_data to callers. This patch-set adds a new function >> irq_get_trigger_type() to obtain the edge/level flags for an IRQ >> and updates the places where irq_get_irq_data(irq) was called >> just to obtain the flags from the struct irq_data. >> >> The patch-set is composed of the following patches: >> >> [PATCH 1/7] genirq: add irq_get_trigger_type() to get IRQ flags >> [PATCH 2/7] gpio: mvebu: use irq_get_trigger_type() to get IRQ flags >> [PATCH 3/7] mfd: twl4030-irq: use irq_get_trigger_type() to get IRQ flags >> [PATCH 4/7] mfd: stmpe: use irq_get_trigger_type() to get IRQ flags >> [PATCH 5/7] arm: orion: use irq_get_trigger_type() to get IRQ flags >> [PATCH 6/7] MIPS: octeon: use irq_get_trigger_type() to get IRQ flags >> [PATCH 7/7] irqdomain: use irq_get_trigger_type() to get IRQ flags > > For the whole series: > Acked-by: Grant Likely > Hello Thomas, Do you have any comments on this patch-set? It has been ack'ed by a lot of people so I wonder if you could take it. Thanks a lot and best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/