Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043Ab3FYQET (ORCPT ); Tue, 25 Jun 2013 12:04:19 -0400 Received: from mail-pb0-f48.google.com ([209.85.160.48]:37265 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586Ab3FYQES (ORCPT ); Tue, 25 Jun 2013 12:04:18 -0400 Message-ID: <51C9BF7E.2000000@gmail.com> Date: Tue, 25 Jun 2013 10:04:14 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Adrian Hunter CC: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Frederic Weisbecker , Jiri Olsa , Mike Galbraith , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 15/15] perf tools: fix ppid in thread__fork() References: <1372079772-20803-1-git-send-email-adrian.hunter@intel.com> <1372079772-20803-16-git-send-email-adrian.hunter@intel.com> <51C9BEA1.5000205@gmail.com> In-Reply-To: <51C9BEA1.5000205@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 36 On 6/25/13 10:00 AM, David Ahern wrote: > On 6/24/13 7:16 AM, Adrian Hunter wrote: >> ppid should be assigned to the parents pid. Note >> 'thread__fork()'s only caller 'machine__process_fork_event()' >> ensures that the parents pid is set. >> >> Signed-off-by: Adrian Hunter >> --- >> tools/perf/util/thread.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c >> index e3d4a55..93f3eab 100644 >> --- a/tools/perf/util/thread.c >> +++ b/tools/perf/util/thread.c >> @@ -85,7 +85,7 @@ int thread__fork(struct thread *self, struct thread >> *parent) >> if (map_groups__clone(&self->mg, &parent->mg, i) < 0) >> return -ENOMEM; >> >> - self->ppid = parent->tid; >> + self->ppid = parent->pid_; > > Confused. My patch uses parent->pid and that it what I see in acme's > perf/core branch. When did this become parent->tid? Never mind. Scanned the patch subjects too quickly and jumped over 2 to get to this one. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/