Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595Ab3FYRKU (ORCPT ); Tue, 25 Jun 2013 13:10:20 -0400 Received: from mail-ve0-f170.google.com ([209.85.128.170]:39112 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244Ab3FYRKT (ORCPT ); Tue, 25 Jun 2013 13:10:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130625090253.26584.65072.stgit@aruna-ThinkPad-T420> Date: Tue, 25 Jun 2013 10:10:18 -0700 Message-ID: Subject: Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase From: Tony Luck To: Kees Cook Cc: Aruna Balakrishnaiah , LKML , Jim Keniston , ananth@in.ibm.com, mahesh@linux.vnet.ibm.com, Anton Vorontsov , Colin Cross Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 23 On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook wrote: > On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah > wrote: >> pstore_erase is used to erase the record from the persistent store. >> So if a driver has not defined pstore_erase callback return How do people manage devices like this? With no erase function they just keep getting more and more pstore entries. Eventually they fill up. >> Signed-off-by: Aruna Balakrishnaiah > > Acked-by: Kees Cook Applied - thanks. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/