Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751735Ab3FYRrr (ORCPT ); Tue, 25 Jun 2013 13:47:47 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:54080 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182Ab3FYRrq (ORCPT ); Tue, 25 Jun 2013 13:47:46 -0400 MIME-Version: 1.0 In-Reply-To: <1372177330-28013-4-git-send-email-mika.westerberg@linux.intel.com> References: <1372177330-28013-1-git-send-email-mika.westerberg@linux.intel.com> <1372177330-28013-4-git-send-email-mika.westerberg@linux.intel.com> Date: Tue, 25 Jun 2013 20:47:45 +0300 Message-ID: Subject: Re: [PATCH 3/6] PCI: introduce pci_trim_stale_devices() From: Andy Shevchenko To: Mika Westerberg Cc: Greg Kroah-Hartman , Bjorn Helgaas , "Rafael J. Wysocki" , Jesse Barnes , Yinghai Lu , john.ronciak@intel.com, miles.j.penner@intel.com, bruce.w.allan@intel.com, "Kirill A. Shutemov" , Heikki Krogerus , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 47 On Tue, Jun 25, 2013 at 7:22 PM, Mika Westerberg wrote: > The new function stops and removes the device if it doesn't respond. > If the device responds and it's a bus we apply the function to all > subdevices recursively. > > It's useful for hotplug bus check case, when you need drop all unplugged > devices before looking for new ones. One comment below. > +void pci_trim_stale_devices(struct pci_dev *dev) > +{ > + struct pci_bus *bus = dev->subordinate; > + struct pci_dev *child, *tmp; > + bool alive; > + u32 l; > + > + /* check if the device responds */ > + alive = pci_bus_read_dev_vendor_id(dev->bus, dev->devfn, &l, 0); > + if (!alive) > + pci_stop_and_remove_bus_device(dev); > + > + if (alive && bus) > + list_for_each_entry_safe(child, tmp, &bus->devices, bus_list) > + pci_trim_stale_devices(child); It's not a tail call anyway, so, what about if (!pci_bus_read_dev_vendor_id(dev->bus, dev->devfn, &l, 0)) { pci_stop_and_remove_bus_device(dev); } else if (bus) { list_for_each_entry_safe(child, tmp, &bus->devices, bus_list) pci_trim_stale_devices(child); } > +} -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/