Message-ID: <1372183005.1245.72.camel@joe-AO722>
Subject: Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jason Baron <jbaron@redhat.com>, shigekatsu.tateno@atmel.com,
        devel@linuxdriverproject.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Tue, 25 Jun 2013 10:56:45 -0700
In-Reply-To: <20130625173840.GA8930@kroah.com>
References: <1372177802-11360-1-git-send-email-rupesh.gujare@atmel.com>
	 <20130625170205.GA21328@kroah.com> <1372181390.1245.68.camel@joe-AO722>
	 <20130625173840.GA8930@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1222
Lines: 38

On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote:
> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote:
> > a long needed extension to dev_dbg is to enable classes
> > of messages by level or mask.
> > 
> > There are many existing macros like
> > 
> > #define module_dbg(level, fmt, ...)
> > do {
> > 	if (level >= some_module_var)
> > 		debug_something(...);
> > } while (0)
> > 
> > and
> > 
> > #define module_dbg(mask, fmt, ...)
> > do {
> > 	if (mask & some_module_var)
> > 		debug_something(...)
> > } while (0)
> > 
> > It'd be nice to consolidate those in dev_dbg
> 
> I'd almost recommend that all of them just be removed, because most of
> them were only used for debugging the code the first time it was
> developed, right?  Only for very limited usages would this type of thing
> be needed.

Maybe, though that's hard to know with certainty.
How often module options are used isn't easy to find out.

These forms are sometimes used to reduce object size.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/