Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595Ab3FYTaL (ORCPT ); Tue, 25 Jun 2013 15:30:11 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:37461 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242Ab3FYTaJ (ORCPT ); Tue, 25 Jun 2013 15:30:09 -0400 MIME-Version: 1.0 In-Reply-To: <20130625185111.GL9294@intel.com> References: <1372177330-28013-1-git-send-email-mika.westerberg@linux.intel.com> <1372177330-28013-6-git-send-email-mika.westerberg@linux.intel.com> <20130625183123.GJ9294@intel.com> <20130625185111.GL9294@intel.com> Date: Tue, 25 Jun 2013 22:30:08 +0300 Message-ID: Subject: Re: [PATCH 5/6] PCI: acpiphp: look _RMV method a bit deeper in the hierarhcy From: Andy Shevchenko To: Mika Westerberg Cc: Greg Kroah-Hartman , Bjorn Helgaas , "Rafael J. Wysocki" , Jesse Barnes , Yinghai Lu , john.ronciak@intel.com, miles.j.penner@intel.com, bruce.w.allan@intel.com, "Kirill A. Shutemov" , Heikki Krogerus , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 19 On Tue, Jun 25, 2013 at 9:51 PM, Mika Westerberg wrote: > On Tue, Jun 25, 2013 at 09:31:52PM +0300, Andy Shevchenko wrote: > I think it is better to remove the first value check from the > pcihp_evaluate_rmv() and keep the check here. > > I'll fix that in the next revision as well. In that case you may remove the removable assignment as well. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/