Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421Ab3FYU5I (ORCPT ); Tue, 25 Jun 2013 16:57:08 -0400 Received: from mail-vb0-f52.google.com ([209.85.212.52]:63650 "EHLO mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711Ab3FYU5G (ORCPT ); Tue, 25 Jun 2013 16:57:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130625125437.6e7bb2d4@jbarnes-desktop> <20130625130816.55e6cb80@jbarnes-desktop> Date: Tue, 25 Jun 2013 23:57:04 +0300 X-Google-Sender-Auth: 8X9N06OmyGoc8GHjt2aJ31sVzqg Message-ID: Subject: Re: Linux 3.10-rc7 From: Tomas Winkler To: Shuah Khan Cc: Jesse Barnes , Daniel Vetter , Linus Torvalds , Chris Wilson , Linux Kernel Mailing List , "shuahkhan@gmail.com" , Dave Airlie , intel-gfx Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 63 On Tue, Jun 25, 2013 at 11:51 PM, Shuah Khan wrote: > > On 06/25/2013 02:06 PM, Jesse Barnes wrote: > > On Tue, 25 Jun 2013 19:59:28 +0000 > > Shuah Khan wrote: > > > >> On 06/25/2013 01:52 PM, Jesse Barnes wrote: > >>> On Tue, 25 Jun 2013 21:37:37 +0200 > >>> Daniel Vetter wrote: > >>> > >> > >>>> > >>>> Adding more lists to cc + Jesse since he's the guilty one for the > >>>> vt-switchless state restore stuff. > >>> > >>> Yeah, looks like we don't fetch the PLL state on resume from > >>> hibernate, > >>> leading to this warning. The refcount is nonzero, indicating the pll > >>> is in use, but the active field is clear, which means we're missing an > >>> update somewhere. > >>> > >>> Shuah, just to confirm, does your resume actually work ok aside from > >>> the warning? I *think* it's harmless in this case, but does indicate > >>> a > >>> real bug in our state tracking... trying to come up with a patch now. > >>> > >>> Thanks, > >>> > >> > >> Resume works just fine. I see it take longer for it to suspend compared > >> to 3.9.7 and then resumes just fine. Suspend taking longer very well > >> could be because of this warn_on. Other than this warn_on I haven't > >> noticed any other problems. > > > > Here's the patch I'm testing now, can you give it a try? > > > > Jesse, > > With this patch warn_on went away. Resume worked. I started seeing: > > [ 78.733062] mei_me 0000:00:16.0: unexpected reset: dev_state = > RESETTING > [ 78.733079] mei_me 0000:00:16.0: reset: wrong host start response > [ 78.733082] mei_me 0000:00:16.0: unexpected reset: dev_state = > RESETTING > > over and over again after resume from reboot mode suspend. dmesg filled > up with these messages. Can you please send me the log part when this starts? Thanks > I did suspend to disk shutdown mode right away. Resume worked, no > warn_ons, and no mei_me messages. > > -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/