Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881Ab3FZCbA (ORCPT ); Tue, 25 Jun 2013 22:31:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44912 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251Ab3FZCa6 (ORCPT ); Tue, 25 Jun 2013 22:30:58 -0400 Date: Tue, 25 Jun 2013 19:31:43 -0700 From: Greg Kroah-Hartman To: Darren Hart Cc: Linux Kernel Mailing List , "H. Peter Anvin" , peter.p.waskiewicz.jr@intel.com, andriy.shevchenko@linux.intel.com, danders@circuitco.com, vishal.l.verma@intel.com, Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH 2/8] pch_uart: Add uart_clk selection for the MinnowBoard Message-ID: <20130626023143.GB23320@kroah.com> References: <6cc125b9eb85dd3cae4a2496fdb7f0d17b18f930.1372211451.git.dvhart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cc125b9eb85dd3cae4a2496fdb7f0d17b18f930.1372211451.git.dvhart@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1848 Lines: 47 On Tue, Jun 25, 2013 at 06:53:22PM -0700, Darren Hart wrote: > Use DMI_BOARD_NAME to determine if we are running on a MinnowBoard and > set the uart clock to 50MHz if so. This removes the need to pass the > user_uartclk to the kernel at boot time. > > Signed-off-by: Darren Hart > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: "H. Peter Anvin" > Cc: Peter Waskiewicz > Cc: Andy Shevchenko > Cc: linux-serial@vger.kernel.org > --- > drivers/tty/serial/pch_uart.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c > index 21a7e17..572d481 100644 > --- a/drivers/tty/serial/pch_uart.c > +++ b/drivers/tty/serial/pch_uart.c > @@ -217,6 +217,7 @@ enum { > #define FRI2_64_UARTCLK 64000000 /* 64.0000 MHz */ > #define FRI2_48_UARTCLK 48000000 /* 48.0000 MHz */ > #define NTC1_UARTCLK 64000000 /* 64.0000 MHz */ > +#define MINNOW_UARTCLK 50000000 /* 50.0000 MHz */ > > struct pch_uart_buffer { > unsigned char *buf; > @@ -398,6 +399,10 @@ static int pch_uart_get_uartclk(void) > strstr(cmp, "nanoETXexpress-TT"))) > return NTC1_UARTCLK; > > + cmp = dmi_get_system_info(DMI_BOARD_NAME); > + if (cmp && strstr(cmp, "MinnowBoard")) > + return MINNOW_UARTCLK; > + You know, we do have the DMI interface to handle this in a much nicer way instead of just randomly trying different strings over and over until we find one that matches... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/