Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112Ab3FZDBA (ORCPT ); Tue, 25 Jun 2013 23:01:00 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:46919 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445Ab3FZDA5 (ORCPT ); Tue, 25 Jun 2013 23:00:57 -0400 MIME-Version: 1.0 In-Reply-To: <51C08BEA.1030804@gmail.com> References: <1369583597-3801-1-git-send-email-jiang.liu@huawei.com> <1369583597-3801-16-git-send-email-jiang.liu@huawei.com> <20130617201802.GB7877@google.com> <51C08BEA.1030804@gmail.com> From: Bjorn Helgaas Date: Tue, 25 Jun 2013 21:00:37 -0600 Message-ID: Subject: Re: [PATCH v3, part2 15/20] PCI, EDAC: use hotplug-safe PCI bus iterators to walk PCI buses To: Jiang Liu Cc: Yinghai Lu , Jiang Liu , "Rafael J . Wysocki" , Greg Kroah-Hartman , Gu Zheng , Toshi Kani , Myron Stowe , Yijing Wang , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab , Doug Thompson , linux-edac@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 44 On Tue, Jun 18, 2013 at 10:33 AM, Jiang Liu wrote: > On 06/18/2013 04:18 AM, Bjorn Helgaas wrote: >> On Sun, May 26, 2013 at 11:53:12PM +0800, Jiang Liu wrote: >>> Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses. >>> >>> Signed-off-by: Jiang Liu >>> Cc: Mauro Carvalho Chehab >>> Cc: Doug Thompson r >>> Cc: linux-edac@vger.kernel.org >>> Cc: linux-kernel@vger.kernel.org >>> --- >>> drivers/edac/i7core_edac.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c >>> index 0ec3e95..7146e10 100644 >>> --- a/drivers/edac/i7core_edac.c >>> +++ b/drivers/edac/i7core_edac.c >>> @@ -1296,7 +1296,7 @@ static unsigned i7core_pci_lastbus(void) >>> int last_bus = 0, bus; >>> struct pci_bus *b = NULL; >>> >>> - while ((b = pci_find_next_bus(b)) != NULL) { >>> + for_each_pci_root_bus(b) { >> >> This doesn't look equivalent. Previously, we iterated over all PCI >> buses, so we returned the highest bus number seen anywhere. Now we >> only look at root buses, so we return the highest bus number of any >> root bus. But if that root bus has a bridge on it, obviously the >> bus on the other side has a higher number. > Hi Bjorn, > I think the name pci_find_next_bus() is misleading, it should be named > pci_find_next_root_bus() actually because it returns next root bus indeed. Oh, you forgot to mention that critical bit of information! That should be in the changelog of every patch that changes a call to pci_find_next_bus(). Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/